Skip to content

Commit

Permalink
Auto merge of #37095 - petrochenkov:metactor, r=alexcrichton
Browse files Browse the repository at this point in the history
Temporary fix for metadata decoding for struct constructors

Same as #37078, but for nightly.
Ideally, metadata lookup functions should "just work" for constructor ids, but this fixes the issue as well.

Fixes #37026
r? @alexcrichton
  • Loading branch information
bors authored Oct 12, 2016
2 parents 0b2c356 + f5827d0 commit a29c49f
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/librustc/ty/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2323,7 +2323,11 @@ impl<'a, 'gcx, 'tcx> TyCtxt<'a, 'gcx, 'tcx> {
let enum_did = self.parent_def_id(did).unwrap();
self.lookup_adt_def(enum_did).variant_with_id(did)
}
Def::Struct(did) | Def::StructCtor(did, ..) | Def::Union(did) => {
Def::Struct(did) | Def::Union(did) => {
self.lookup_adt_def(did).struct_variant()
}
Def::StructCtor(ctor_did, ..) => {
let did = self.parent_def_id(ctor_did).expect("struct ctor has no parent");
self.lookup_adt_def(did).struct_variant()
}
_ => bug!("expect_variant_def used with unexpected def {:?}", def)
Expand Down
18 changes: 18 additions & 0 deletions src/test/compile-fail/issue-37026.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
// Copyright 2016 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// aux-build:empty-struct.rs

extern crate empty_struct;

fn main() {
let empty_struct::XEmpty2 = (); //~ ERROR mismatched types
let empty_struct::XEmpty6(..) = (); //~ ERROR mismatched types
}

0 comments on commit a29c49f

Please sign in to comment.