Skip to content

Commit

Permalink
disable missing_copy_implementations lint on non_exhaustive types
Browse files Browse the repository at this point in the history
use is_variant_list_non_exhaustive/is_field_list_non_exhaustive

remove unused tcx

inline non_exhaustive def/variant check
  • Loading branch information
rmehri01 committed Oct 17, 2023
1 parent eea2614 commit a8e7e79
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 0 deletions.
5 changes: 5 additions & 0 deletions compiler/rustc_lint/src/builtin.rs
Original file line number Diff line number Diff line change
Expand Up @@ -677,6 +677,11 @@ impl<'tcx> LateLintPass<'tcx> for MissingCopyImplementations {
if type_implements_negative_copy_modulo_regions(cx.tcx, ty, param_env) {
return;
}
if def.is_variant_list_non_exhaustive()
|| def.variants().iter().any(|variant| variant.is_field_list_non_exhaustive())
{
return;
}

// We shouldn't recommend implementing `Copy` on stateful things,
// such as iterators.
Expand Down
25 changes: 25 additions & 0 deletions tests/ui/lint/missing-copy-implementations-non-exhaustive.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
// Test for issue #116766.
// Ensure that we don't suggest impl'ing `Copy` for a type if it or at least one
// of it's variants are marked as `non_exhaustive`.

// check-pass

#![deny(missing_copy_implementations)]

#[non_exhaustive]
pub enum MyEnum {
A,
}

#[non_exhaustive]
pub struct MyStruct {
foo: usize,
}

pub enum MyEnum2 {
#[non_exhaustive]
A,
B,
}

fn main() {}

0 comments on commit a8e7e79

Please sign in to comment.