Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix passing self by value for types passed by value
For types that are passed by value, we can't just cast the value to a pointer, but have to use an alloca and copy the value there. This handling is already present for all other arguments, but was missing for "self". Fixes #6682, #4850 and #4878
- Loading branch information
b51f44e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from catamorphism
at dotdash@b51f44e
b51f44e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging dotdash/rust/self_by_value = b51f44e into auto
b51f44e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dotdash/rust/self_by_value = b51f44e merged ok, testing candidate = 4f6285f
b51f44e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
http://buildbot.rust-lang.org/builders/auto-linux/builds/1548
http://buildbot.rust-lang.org/builders/auto-win/builds/1543
http://buildbot.rust-lang.org/builders/auto-mac/builds/1562
b51f44e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding incoming to auto = 4f6285f