Skip to content

Commit

Permalink
Disabled SHELL=dash on Windows due to invalid path backslash handling
Browse files Browse the repository at this point in the history
Calling an executable via full path with Windows backslashes fails in
dash.
  • Loading branch information
richkadel committed Feb 13, 2021
1 parent b211acf commit cbe6c70
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/test/run-make-fulldeps/tools.mk
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,11 @@ DIFF := diff -u --strip-trailing-cr
# whenever possible. Most developer platforms include `/bin/dash`, but to ensure
# tests still work when `/bin/dash`, if not available, this `SHELL` override is
# conditional:
ifndef IS_WINDOWS # dash interprets backslashes in executable paths incorrectly
ifneq (,$(wildcard /bin/dash))
SHELL := /bin/dash
endif
endif

# This is the name of the binary we will generate and run; use this
# e.g. for `$(CC) -o $(RUN_BINFILE)`.
Expand Down

0 comments on commit cbe6c70

Please sign in to comment.