Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
rustdoc: Set a nonzero exit status on failure
Now that rustdoc is spawning a child task, the program won't exit with a default error code if the main task fails (because it never fails). This commit forces the main task to wait for a child task in order to correctly propagate failure. Closes #16341
- Loading branch information
d9038fc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from huonw
at alexcrichton@d9038fc
d9038fc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging alexcrichton/rust/issue-16341 = d9038fc into auto
d9038fc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alexcrichton/rust/issue-16341 = d9038fc merged ok, testing candidate = beda30e
d9038fc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/757
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/757
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/756
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/757
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/753
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/754
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/753
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/759
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/754
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/753
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/756
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/754
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/754
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/755
d9038fc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = beda30e