Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta] RELEASES.md isn't rendered on GitHub.com #101714

Closed
LDVSOFT opened this issue Sep 12, 2022 · 10 comments
Closed

[Meta] RELEASES.md isn't rendered on GitHub.com #101714

LDVSOFT opened this issue Sep 12, 2022 · 10 comments
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself T-release Relevant to the release subteam, which will review and decide on the PR/issue.

Comments

@LDVSOFT
Copy link

LDVSOFT commented Sep 12, 2022

Hi, Rust contributors!

Take a look at Rust releases file: https://github.com/rust-lang/rust/blob/master/RELEASES.md. For me, GitHub just states that rendering it took too long, so it won't show it. In my opinion rendering Markdown shouldn't be so hard to render a rarely updated half-megabyte file, but it's to GitHub developers who are managing the platform and their workload might dictate the limits. However, even if the current file could be rendered, it will still continue to grow with each release.

I see several ways to tackle this problem:

  • Keep things as they are right now. Even if Releases isn't viewable on the GitHub website, you can still read it sources or view in editor/IDE that can show rendered MarkDown, and I guess releases blog posts are very similar to a separate chapter of that file.
  • Contact GitHub team, maybe they could provide a solution or advice from their side.
  • Split RELEASES.md. file. Several other projects use several Releases / ChangeLog files, so that every one of those isn't that big. However, it often comes from the fact that they have a deeper versioning scheme, where every file represents one major or minor series, i.e. 1.* or 1.2.*, and are created rarely, while fixes releases are much more often. Rust versions since 1.0 aren't like that, we for the most time just have incrementing minor version with rare bug-fixing releases. I have a quick thought that we could just aggregate those by 10 or by release a year, but it requires further thoughts on UX of the whole thing.
    • What we could do is to add just one "older releases" and only keep several recent ones (like, for a year) in a RELEASES.md.

Anyway, those are just my thoughts, and maybe tomorrow the file will still be viewable as it has been before.

@ChrisDenton
Copy link
Member

This is also being discussed on Zulip but it's good to have an issue to track it.

@Rageking8
Copy link
Contributor

Rageking8 commented Sep 12, 2022

Another thing that may be of interest is that the RELEASES.md file successfully renders on the GitHub Android App although it's a bit jittery. Problem might be web specific.

@Rageking8
Copy link
Contributor

@rustbot label +A-meta

@rustbot rustbot added the A-meta Area: Issues & PRs about the rust-lang/rust repository itself label Sep 12, 2022
@ehuss ehuss added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label May 15, 2023
@tanriol
Copy link
Contributor

tanriol commented May 30, 2023

Note that the pre-release testing blog post links to RELEASES.md on GitHub that fails to render for some people, and that does not feel good.

@VitWW
Copy link

VitWW commented May 31, 2023

A quick alternative -

  1. remain RELEASES.md as is
  2. add a file RELEASESRecent.md (or RELEASES2020.md), which starts from Version 1.40.0 (2019-12-19) (~1/3 of full size) and above and has a link to full RELEASES.md
  3. Use link RELEASESRecent.md in public posts

@simonbuchan
Copy link
Contributor

Some other options for splitting it up:

  • RELEASE_$VERSION.md (and RELEASES.md being an index?) - would probably make it too annoying to find a specific change
  • A current RELEASES.md and RELEASES_$FROM_$TO.md broken out each time it gets too big - a little weird and guaranteed worst viewing performance.
  • An index RELEASES.md with version ranges for RELEASES_$YEAR.md - I kind of like this one?

@djc
Copy link
Contributor

djc commented May 31, 2023

I put up an MVP PR in #112135.

notriddle added a commit to notriddle/rust that referenced this issue Nov 13, 2023
This is a workaround for rust-lang#101714 on top of being a useful addition
in its own right. It is intended to change the "canonical URL"
for viewing the release notes from GitHub, which is relatively
slow, to a pre-rendered HTML file that loads from the same CDN
as the standard library docs. It also means you get a copy of
the release notes when installing the rust-docs with rustup.
notriddle added a commit to notriddle/rust that referenced this issue Nov 13, 2023
This is a workaround for rust-lang#101714 on top of being a useful addition
in its own right. It is intended to change the "canonical URL"
for viewing the release notes from GitHub, which is relatively
slow, to a pre-rendered HTML file that loads from the same CDN
as the standard library docs. It also means you get a copy of
the release notes when installing the rust-docs with rustup.
notriddle added a commit to notriddle/rust that referenced this issue Nov 13, 2023
This is a workaround for rust-lang#101714 on top of being a useful addition
in its own right. It is intended to change the "canonical URL"
for viewing the release notes from GitHub, which is relatively
slow, to a pre-rendered HTML file that loads from the same CDN
as the standard library docs. It also means you get a copy of
the release notes when installing the rust-docs with rustup.
bors added a commit to rust-lang-ci/rust that referenced this issue Nov 19, 2023
…-Simulacrum

doc: add release notes to standalone doc bundle

Preview: http://notriddle.com/rustdoc-html-demo-5/release-notes/releases.html

This is a workaround for rust-lang#101714 on top of being a useful addition in its own right. It is intended to change the "canonical URL" for viewing the release notes from GitHub, which is relatively slow, to a pre-rendered HTML file that loads from the same CDN as the standard library docs. It also means you get a copy of the release notes when installing the rust-docs with rustup.
@bstrie
Copy link
Contributor

bstrie commented Nov 25, 2023

What if we change it from a Markdown file to a text file? Markdown is designed to be mostly-readable in text mode, so it wouldn't be that big of a change (nobody would have to go through and rewrite the whole file), and better to be able to read raw text rather than read nothing at all. As for breaking links, this will only break links that don't include the hash (remember you can press y on any Github page to get a link that includes the git hash), and those links are already going to be broken if the file fails to render, so...

notriddle added a commit to notriddle/promote-release that referenced this issue Feb 4, 2024
Mark-Simulacrum pushed a commit to rust-lang/promote-release that referenced this issue Feb 4, 2024
@LDVSOFT
Copy link
Author

LDVSOFT commented Feb 13, 2024

I must note that I don't what is the cause, but now the file is actually rendered all the way to 2012! So, looks like the issue might be solved on GitHub side, but I'd like an opinion of project management.

@WaffleLapkin
Copy link
Member

We might want to consider moving future releases to different file(s), to prevent errors like that in the future. But the issue at hand indeed seems to be fixed on github side.

Even though I'm no project management, I'm going to go ahead and close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.