Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking Issue for feature(const_slice_split_at_mut) #101804

Closed
3 of 6 tasks
onestacked opened this issue Sep 14, 2022 · 7 comments · Fixed by #130428
Closed
3 of 6 tasks

Tracking Issue for feature(const_slice_split_at_mut) #101804

onestacked opened this issue Sep 14, 2022 · 7 comments · Fixed by #130428
Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@onestacked
Copy link
Contributor

onestacked commented Sep 14, 2022 •
edited
Loading

Feature gate: #![feature(const_slice_split_at_mut)]

This is a tracking issue for spliting mutable slices in const context.

Public API

// slice
pub const fn split_at_mut(&mut self, mid: usize) -> (&mut [T], &mut [T]);
pub const fn split_at_mut_unchecked(&mut self, mid: usize) -> (&mut [T], &mut [T]);
pub const fn split_at_mut_checked(&mut self, mid: usize) -> Option<(&mut [T], &mut [T])>;

Steps / History

Unresolved Questions

  • None yet.

Footnotes

  1. https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html ↩
@onestacked onestacked added C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Sep 14, 2022
@onestacked onestacked mentioned this issue Sep 14, 2022
Merged
fee1-dead added a commit to fee1-dead-contrib/rust that referenced this issue Sep 25, 2022
@fee1-dead
Rollup merge of rust-lang#101800 - chriss0612:feat/const_split_at_mut…
da884d2 
…, r=fee1-dead

Constify slice.split_at_mut(_unchecked)

Tracking Issue: [Tracking Issue for const_slice_split_at_mut](rust-lang#101804)

Feature gate: `#![feature(const_slice_split_at_mut)]`

Still requires const_mut_refs to be actually used, but this feature removes the need to manually re implement these functions in a user crate.
@lcnr lcnr changed the title Tracking Issue for const_slice_split_at_mut Tracking Issue for feature(const_slice_split_at_mut) Sep 26, 2022
thomcc pushed a commit to tcdi/postgrestd that referenced this issue Feb 10, 2023
@fee1-dead
Rollup merge of #101800 - chriss0612:feat/const_split_at_mut, r=fee1-…
4514c07 
…dead

Constify slice.split_at_mut(_unchecked)

Tracking Issue: [Tracking Issue for const_slice_split_at_mut](rust-lang/rust#101804)

Feature gate: `#![feature(const_slice_split_at_mut)]`

Still requires const_mut_refs to be actually used, but this feature removes the need to manually re implement these functions in a user crate.
@UserIsntAvailable UserIsntAvailable mentioned this issue May 3, 2024
Merged
compiler-errors added a commit to compiler-errors/rust that referenced this issue May 4, 2024
@compiler-errors
Rollup merge of rust-lang#124678 - UserIsntAvailable:feat/stabilize-s…
baea702 
…plit-at-checked, r=jhpratt

Stabilize `split_at_checked`

Closes rust-lang#119128

For the const version of `slice::split_at_mut_checked`, I'm reusing the `const_slice_split_at_mut` feature flag (rust-lang#101804). I don't if it okay to reuse tracking issues or if it preferred to create new ones...
compiler-errors added a commit to compiler-errors/rust that referenced this issue May 4, 2024
@compiler-errors
Rollup merge of rust-lang#124678 - UserIsntAvailable:feat/stabilize-s…
93ca906 
…plit-at-checked, r=jhpratt

Stabilize `split_at_checked`

Closes rust-lang#119128

For the const version of `slice::split_at_mut_checked`, I'm reusing the `const_slice_split_at_mut` feature flag (rust-lang#101804). I don't if it okay to reuse tracking issues or if it preferred to create new ones...
rust-timer added a commit to rust-lang-ci/rust that referenced this issue May 4, 2024
@rust-timer
Unrolled build for rust-lang#124678
88c0702 
Rollup merge of rust-lang#124678 - UserIsntAvailable:feat/stabilize-split-at-checked, r=jhpratt

Stabilize `split_at_checked`

Closes rust-lang#119128

For the const version of `slice::split_at_mut_checked`, I'm reusing the `const_slice_split_at_mut` feature flag (rust-lang#101804). I don't if it okay to reuse tracking issues or if it preferred to create new ones...
@RalfJung RalfJung added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Sep 6, 2024
@RalfJung
Copy link
Member

RalfJung commented Sep 6, 2024

@rust-lang/libs-api this should be ready for stabilization now, once const_mut_refs is stable. :)

@dtolnay
Copy link
Member

dtolnay commented Sep 6, 2024 •
edited
Loading

@rfcbot fcp merge

const for these 3 already-stable functions:

@rfcbot
Copy link

rfcbot commented Sep 6, 2024 •
edited by Amanieu
Loading

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Sep 6, 2024
@dtolnay dtolnay removed the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Sep 6, 2024
@okaneco
Copy link
Contributor

okaneco commented Sep 6, 2024

split_at_mut_checked's const stability was placed under this feature in #124678
https://doc.rust-lang.org/nightly/core/primitive.slice.html#method.split_at_mut_checked

@dtolnay
Copy link
Member

dtolnay commented Sep 6, 2024

Good call. Added it to the Public API description and the stabilization proposal.

@onestacked onestacked mentioned this issue Sep 16, 2024
Merged
@workingjubilee workingjubilee mentioned this issue Sep 19, 2024
Closed
8 tasks
@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Sep 24, 2024
@rfcbot
Copy link

rfcbot commented Sep 24, 2024

🔔 This is now entering its final comment period, as per the review above. 🔔

@eduardosm eduardosm mentioned this issue Sep 24, 2024
Closed
1 task
@RalfJung RalfJung mentioned this issue Sep 29, 2024
Closed
6 tasks
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Oct 4, 2024
@rfcbot
Copy link

rfcbot commented Oct 4, 2024

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@rustbot rustbot mentioned this issue Oct 4, 2024
Open
3 tasks
@bors bors closed this as completed in 386a0ba Oct 5, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Oct 5, 2024
@rust-timer
Unrolled build for rust-lang#130428
df832ae 
Rollup merge of rust-lang#130428 - ink-feather-org:stabilize-const-split-at-mut, r=RalfJung

Stabilize `const_slice_split_at_mut` and `const_slice_first_last_chunk`

Stabilizes rust-lang#101804 and the remainder of rust-lang#111774.

FCP proposed in the tracking issue.

Requires rust-lang#130403 (or it would need a rustc_allow_const_fn_unstable for it)

Stabilized const API:
```rust
// slice
impl [T] {
    pub const fn split_at_mut(&mut self, mid: usize) -> (&mut [T], &mut [T]);
    pub const fn split_at_mut_unchecked(&mut self, mid: usize) -> (&mut [T], &mut [T]);
    pub const fn split_at_mut_checked(&mut self, mid: usize) -> Option<(&mut [T], &mut [T])>;

    pub const fn first_chunk_mut<const N: usize>(&mut self) -> Option<&mut [T; N]>;
    pub const fn last_chunk_mut<const N: usize>(&mut self) -> Option<&mut [T; N]>;
    pub const fn split_first_chunk_mut<const N: usize>(&mut self) -> Option<(&mut [T; N], &mut [T])>;
    pub const fn split_last_chunk_mut<const N: usize>(&mut self) -> Option<(&mut [T; N], &mut [T])>;
}
```

Closes rust-lang#101804
Closes rust-lang#111774

cc `@RalfJung`
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stabilize const_slice_split_at_mut and const_slice_first_last_chunk ink-feather-org/rust
6 participants
@RalfJung @dtolnay @apiraino @onestacked @rfcbot @okaneco