Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: trait bound not satisfied #103243

Closed
Mark-Simulacrum opened this issue Oct 19, 2022 · 6 comments
Closed

regression: trait bound not satisfied #103243

Mark-Simulacrum opened this issue Oct 19, 2022 · 6 comments
Assignees
Labels
P-critical Critical priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone

Comments

@Mark-Simulacrum Mark-Simulacrum added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. E-needs-bisection Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc labels Oct 19, 2022
@Mark-Simulacrum Mark-Simulacrum added this to the 1.65.0 milestone Oct 19, 2022
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Oct 19, 2022
@compiler-errors
Copy link
Member

This regressed in #98900, cc @lcnr - I may take a look at this later today.

@compiler-errors compiler-errors removed the E-needs-bisection Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc label Oct 19, 2022
@compiler-errors
Copy link
Member

The regression in diesel-softdelete is separate and regressed in #100757 cc @ouz-a

@compiler-errors
Copy link
Member

compiler-errors commented Oct 20, 2022

I minimized this from path-planning:

pub trait CSpace<const N: usize>: Sized {
    type Traj;
}

pub trait FullTrajectory<T, S1, const N: usize> {}

pub struct Const<const R: usize>;

pub trait Obstacle<CS, const N: usize>
where
    CS: CSpace<N>,
{
    fn trajectory_free<FT, S1>(&self, t: &FT)
    where
        FT: FullTrajectory<CS::Traj, S1, N>;
}

// -----

const N: usize = 4;

struct ObstacleSpace2df32;

impl<CS> Obstacle<CS, N> for ObstacleSpace2df32
where
    CS: CSpace<N>,
{
    fn trajectory_free<TF, S1>(&self, t: &TF)
    where
        TF: FullTrajectory<CS::Traj, S1, N>,
    {}
}

@compiler-errors
Copy link
Member

I put up a potential fix in #103279

@apiraino
Copy link
Contributor

WG-prioritization assigning priority (Zulip discussion).

@rustbot label -I-prioritize +P-critical

@rustbot rustbot added P-critical Critical priority and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Oct 20, 2022
@compiler-errors compiler-errors self-assigned this Oct 20, 2022
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 26, 2022
… r=lcnr

Add eval hack in `super_relate_consts` back

Partially reverts 01adb7e.

This extra eval call *still* needs to happen, for example, in `normalize_param_env_or_error` when a param-env predicate has an unnormalized constant, since the param-env candidates never get normalized during candidate assembly (everywhere else we can assume that they are normalized fully).

r? `@lcnr,` though I feel like I've assigned quite a few PRs to you in the last few days, so feel free to reassign to someone else familiar with this code if you're busy!

cc rust-lang#103243 (fixes the issue, but don't want to auto-close that until a backport is performed).
@compiler-errors
Copy link
Member

1.65 is released

Aaron1011 pushed a commit to Aaron1011/rust that referenced this issue Jan 6, 2023
… r=lcnr

Add eval hack in `super_relate_consts` back

Partially reverts 01adb7e.

This extra eval call *still* needs to happen, for example, in `normalize_param_env_or_error` when a param-env predicate has an unnormalized constant, since the param-env candidates never get normalized during candidate assembly (everywhere else we can assume that they are normalized fully).

r? `@lcnr,` though I feel like I've assigned quite a few PRs to you in the last few days, so feel free to reassign to someone else familiar with this code if you're busy!

cc rust-lang#103243 (fixes the issue, but don't want to auto-close that until a backport is performed).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-critical Critical priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants