Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

array::map_8byte_256byte_256 benchmark causes stack overflow #108011

Closed
Sp00ph opened this issue Feb 13, 2023 · 2 comments · Fixed by #108023
Closed

array::map_8byte_256byte_256 benchmark causes stack overflow #108011

Sp00ph opened this issue Feb 13, 2023 · 2 comments · Fixed by #108023
Labels
C-bug Category: This is a bug.

Comments

@Sp00ph
Copy link
Member

Sp00ph commented Feb 13, 2023

Running python x.py test --stage=0 library/core causes a stack overflow on my machine (64-Bit Windows 11, Build 22621.1105) on the benchmark array::map_8byte_256byte_256 which was recently added in #107915.

cc @JulianKnodt

rustc --version --verbose:

rustc 1.69.0-nightly (5b8f28453 2023-02-12)
binary: rustc
commit-hash: 5b8f284536d00ba649ca968584bedab4820d8527
commit-date: 2023-02-12
host: x86_64-pc-windows-msvc
release: 1.69.0-nightly
LLVM version: 15.0.7
@Sp00ph Sp00ph added the C-bug Category: This is a bug. label Feb 13, 2023
@JulianKnodt
Copy link
Contributor

If you reduce the size of the benchmarks by 10 (from 25600 elements to 2560), does that still cause stack overflow? I don't think CI reproduces this, and I can't reproduce it since I don't have a machine for it.

@Sp00ph
Copy link
Member Author

Sp00ph commented Feb 13, 2023

Yes, reducing the sizes for map_256byte_8byte_256 and map_8byte_256byte_256 to 2560 fixes the overflow on my machine.

@JulianKnodt JulianKnodt mentioned this issue Feb 14, 2023
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue Feb 14, 2023
@Dylan-DPC
Rollup merge of rust-lang#108023 - JulianKnodt:smaller_benchmark, r=w…
b8d1547 
…orkingjubilee

Shrink size of array benchmarks

Might've overdone it with the size of these benchmarks, as there's no need for them to be quite as large.

Fixes rust-lang#108011
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 14, 2023
@matthiaskrgr
Rollup merge of rust-lang#108023 - JulianKnodt:smaller_benchmark, r=w…
d5efe29 
…orkingjubilee

Shrink size of array benchmarks

Might've overdone it with the size of these benchmarks, as there's no need for them to be quite as large.

Fixes rust-lang#108011
@bors bors closed this as completed in d599be0 Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Shrink size of array benchmarks JulianKnodt/rust
2 participants
@JulianKnodt @Sp00ph