Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AscribeUserType statements contain variance which should be carried by NonUseContext::AscribeUserTy #108267

Closed
lcnr opened this issue Feb 20, 2023 · 3 comments · Fixed by #111366
Closed

AscribeUserType statements contain variance which should be carried by NonUseContext::AscribeUserTy #108267

lcnr opened this issue Feb 20, 2023 · 3 comments · Fixed by #111366
Assignees
@obeis
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@lcnr
Copy link
Contributor

lcnr commented Feb 20, 2023 •
edited by rustbot
Loading

Originally posted by @cjgillot in #107969 (comment), see that PR discussion for more detail
@lcnr lcnr added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Feb 20, 2023
@obeis
Copy link
Contributor

obeis commented Feb 21, 2023

@rustbot claim

@lcnr
Copy link
Contributor Author

lcnr commented May 5, 2023

@obeis are you still looking into this? If so, please reassign yourself

@lcnr lcnr unassigned obeis May 5, 2023
@obeis
Copy link
Contributor

obeis commented May 8, 2023

@rustbot claim

@obeis obeis mentioned this issue May 8, 2023
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue May 11, 2023
@Dylan-DPC
Rollup merge of rust-lang#111366 - obeis:ascribe-user-type-variance, …
433183d 
…r=lcnr

Make `NonUseContext::AscribeUserTy` carry `ty::Variance`

Close rust-lang#108267
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue May 11, 2023
@matthiaskrgr
Rollup merge of rust-lang#111366 - obeis:ascribe-user-type-variance, …
e1746af 
…r=lcnr

Make `NonUseContext::AscribeUserTy` carry `ty::Variance`

Close rust-lang#108267
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue May 11, 2023
@matthiaskrgr
Rollup merge of rust-lang#111366 - obeis:ascribe-user-type-variance, …
472f2e0 
…r=lcnr

Make `NonUseContext::AscribeUserTy` carry `ty::Variance`

Close rust-lang#108267
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue May 11, 2023
@matthiaskrgr
Rollup merge of rust-lang#111366 - obeis:ascribe-user-type-variance, …
7e311dd 
…r=lcnr

Make `NonUseContext::AscribeUserTy` carry `ty::Variance`

Close rust-lang#108267
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue May 11, 2023
@matthiaskrgr
Rollup merge of rust-lang#111366 - obeis:ascribe-user-type-variance, …
a136959 
…r=lcnr

Make `NonUseContext::AscribeUserTy` carry `ty::Variance`

Close rust-lang#108267
@bors bors closed this as completed in 41ab8e6 May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@obeis obeis

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make NonUseContext::AscribeUserTy carry ty::Variance obeis/rust
2 participants
@lcnr @obeis