Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stable Rustdoc Book suggests missing_doc_code_examples, which is unstable #109601

Closed
peter-lyons-kehl opened this issue Mar 25, 2023 · 2 comments · Fixed by #109767
Closed

stable Rustdoc Book suggests missing_doc_code_examples, which is unstable #109601

peter-lyons-kehl opened this issue Mar 25, 2023 · 2 comments · Fixed by #109767
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-discussion Category: Discussion or questions that doesn't represent real issues. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@peter-lyons-kehl
Copy link
Contributor

Location

src/doc/rustdoc/src/write-documentation/what-to-include.md (https://doc.rust-lang.org/rustdoc/write-documentation/what-to-include.html)

Summary

Currently, missing_doc_code_examples lint is implemented on nightly and gated with #![feature(rustdoc_missing_doc_code_examples)]. However, the lint #![deny(missing_doc_code_examples)] is suggested in the stable version of Rustdoc Book, too - but without any mention that it's a nightly feature. Is it likely to get stabilized soon (so Rustdoc Book could stay as is)?

Otherwise, shouldn't we document that (and create an issue to remove such a note from the Rustdoc Book once the feature becomes stable)? If so, I'm happy to create an issue and a PR.

Or, should this be pulled out of stable Rustdoc Book until the feature is stabilized? Is there any recommended/de-facto practice for this?
(This issue is a follow up to #109592.)

@peter-lyons-kehl peter-lyons-kehl added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label Mar 25, 2023
@jyn514 jyn514 added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-discussion Category: Discussion or questions that doesn't represent real issues. labels Mar 25, 2023
@jyn514
Copy link
Member

jyn514 commented Mar 25, 2023

missing_doc_code_examples in that section seems strange to me, I don't see how it relates to the rest of the section. It looks like this was present from the first commit where the "write documentation" chapter was added: 881820a#diff-e271d69d7408013ad53dff6ceece67373bc99f2c514cb4ca219a8f20a48e9ebc
I would personally be ok with removing it.

@camelid
Copy link
Member

camelid commented Mar 28, 2023

Removing the mention of missing_doc_code_examples makes sense to me as well. Note that it already has documentation (that notes that it's unstable) on the lints page: https://doc.rust-lang.org/rustdoc/lints.html#missing_doc_code_examples

@bors bors closed this as completed in 4f87a63 Apr 8, 2023
saethlin pushed a commit to saethlin/miri that referenced this issue Apr 10, 2023
…amples, r=notriddle

Remove mention of `missing_doc_code_examples` lint from rustdoc book

Fixes rust-lang/rust#109601.

r? `@notriddle`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-discussion Category: Discussion or questions that doesn't represent real issues. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants