Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: no emojis in lifetime names (despite no emojis being present?) #109746

Closed
Mark-Simulacrum opened this issue Mar 30, 2023 · 6 comments
Closed

regression: no emojis in lifetime names (despite no emojis being present?) #109746

Mark-Simulacrum opened this issue Mar 30, 2023 · 6 comments
Assignees
@compiler-errors
Labels
P-medium Medium priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone
1.69.0

Comments

@Mark-Simulacrum
Copy link
Member

Not clear what the cause here is, but worth figuring out.
@Mark-Simulacrum Mark-Simulacrum added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. E-needs-bisection Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc labels Mar 30, 2023
@Mark-Simulacrum Mark-Simulacrum added this to the 1.69.0 milestone Mar 30, 2023
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Mar 30, 2023
@Mark-Simulacrum Mark-Simulacrum mentioned this issue Mar 30, 2023
Closed
@ehuss
Copy link
Contributor

ehuss commented Mar 30, 2023

Bisected to #108031. cc @jieyouxu / @estebank

@ehuss ehuss removed the E-needs-bisection Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc label Mar 30, 2023
@ehuss
Copy link
Contributor

ehuss commented Mar 30, 2023

BTW, here's a minimal repro:

macro_rules! foo {
    ($tt1:tt) => {};
}

fn x() {
    foo!('me#foo);
}

@estebank estebank self-assigned this Mar 30, 2023
@estebank estebank mentioned this issue Mar 30, 2023
Closed
@estebank
Copy link
Contributor

estebank commented Mar 30, 2023 •
edited
Loading

Thanks for the ping! Fixing it in #109754. (is_emoji counterintuitively considers # as an emoji.)

@estebank estebank mentioned this issue Mar 30, 2023
Open
estebank added a commit to estebank/rust that referenced this issue Mar 30, 2023
@estebank
Do not consider # an emoji in the lexer
a2c1d8a 
Fix rust-lang#109746.
@apiraino
Copy link
Contributor

WG-prioritization assigning priority (Zulip discussion).

@rustbot label -I-prioritize +P-medium

@rustbot rustbot added P-medium Medium priority and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Mar 30, 2023
@estebank
Copy link
Contributor

Update: t-compiler decided to revert the PR that introduced the regression

@estebank estebank removed their assignment Mar 31, 2023
compiler-errors added a commit to compiler-errors/rust that referenced this issue Apr 10, 2023
@compiler-errors
Revert "Don't recover lifetimes/labels containing emojis as character…
a047064 
… literals"

Reverts PR rust-lang#108031
Fixes (doesnt close until beta backported) rust-lang#109746

This reverts commit e3f9db5.
This reverts commit 98b82ae.
This reverts commit 380fa26.
@compiler-errors compiler-errors self-assigned this Apr 10, 2023
@compiler-errors compiler-errors mentioned this issue Apr 10, 2023
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue Apr 10, 2023
@Dylan-DPC
Rollup merge of rust-lang#110135 - compiler-errors:revert-108031, r=d…
0aea6c0 
…avidtwco

Revert "Don't recover lifetimes/labels containing emojis as character literals"

Reverts PR rust-lang#108031 per rust-lang#109754 (comment)

Fixes (doesnt close until beta backported) rust-lang#109746

This reverts commit e3f9db5.
This reverts commit 98b82ae.
This reverts commit 380fa26.
JohnTitor added a commit to JohnTitor/rust that referenced this issue Apr 11, 2023
@JohnTitor
Rollup merge of rust-lang#110135 - compiler-errors:revert-108031, r=d…
296ac2e 
…avidtwco

Revert "Don't recover lifetimes/labels containing emojis as character literals"

Reverts PR rust-lang#108031 per rust-lang#109754 (comment)

Fixes (doesnt close until beta backported) rust-lang#109746

This reverts commit e3f9db5.
This reverts commit 98b82ae.
This reverts commit 380fa26.
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue Apr 11, 2023
@Dylan-DPC
Rollup merge of rust-lang#110135 - compiler-errors:revert-108031, r=d…
d64cfdf 
…avidtwco

Revert "Don't recover lifetimes/labels containing emojis as character literals"

Reverts PR rust-lang#108031 per rust-lang#109754 (comment)

Fixes (doesnt close until beta backported) rust-lang#109746

This reverts commit e3f9db5.
This reverts commit 98b82ae.
This reverts commit 380fa26.
compiler-errors added a commit to compiler-errors/rust that referenced this issue Apr 11, 2023
@compiler-errors
Rollup merge of rust-lang#110135 - compiler-errors:revert-108031, r=d…
b56deeb 
…avidtwco

Revert "Don't recover lifetimes/labels containing emojis as character literals"

Reverts PR rust-lang#108031 per rust-lang#109754 (comment)

Fixes (doesnt close until beta backported) rust-lang#109746

This reverts commit e3f9db5.
This reverts commit 98b82ae.
This reverts commit 380fa26.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Apr 12, 2023
@matthiaskrgr
Rollup merge of rust-lang#110135 - compiler-errors:revert-108031, r=d…
57393be 
…avidtwco

Revert "Don't recover lifetimes/labels containing emojis as character literals"

Reverts PR rust-lang#108031 per rust-lang#109754 (comment)

Fixes (doesnt close until beta backported) rust-lang#109746

This reverts commit e3f9db5.
This reverts commit 98b82ae.
This reverts commit 380fa26.
bors pushed a commit to rust-lang-ci/rust that referenced this issue Apr 16, 2023
@compiler-errors @pietroalbini
Revert "Don't recover lifetimes/labels containing emojis as character…
6ed03e8 
… literals"

Reverts PR rust-lang#108031
Fixes (doesnt close until beta backported) rust-lang#109746

This reverts commit e3f9db5.
This reverts commit 98b82ae.
This reverts commit 380fa26.
@compiler-errors
Copy link
Member

This was reverted in 1.69

MabezDev pushed a commit to esp-rs/rust that referenced this issue May 16, 2023
@compiler-errors @MabezDev
Revert "Don't recover lifetimes/labels containing emojis as character…
3e22715 
… literals"

Reverts PR rust-lang#108031
Fixes (doesnt close until beta backported) rust-lang#109746

This reverts commit e3f9db5.
This reverts commit 98b82ae.
This reverts commit 380fa26.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@compiler-errors compiler-errors

Labels
P-medium Medium priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging a pull request may close this issue.

Do not consider # an emoji in the lexer estebank/rust
6 participants
@ehuss @estebank @compiler-errors @Mark-Simulacrum @apiraino @rustbot