Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put needs-triage label on every new issue #113261

Closed
Noratrieb opened this issue Jul 2, 2023 · 7 comments · Fixed by #113413
Closed

Put needs-triage label on every new issue #113261

Noratrieb opened this issue Jul 2, 2023 · 7 comments · Fixed by #113413
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@Noratrieb
Copy link
Member

The GitHub issue for https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/make.20untriaged.20issues.20explicit so I can nominate it for the teams.

I've noticed that we have many issues inside rust-lang/rust that are completely untriaged with no interactivity. I don't believe that this is due to lack of time, but simply due to lack of organization. I propose that every new issue gets the needs-triage label. Then, members can see the issues with that label and triage them. That includes labeling the issues and maybe replying to them if there's a specific request, for example answering a question or asking for a reproduction. Ideally triage is done by someone with knowledge in the issue's area but that's of course not a hard requirement. The person can then just remove the label. The label can also be settable via rustbot so anyone can do this.

I'm confident that we'd have enough time to triage all issues with that labeling system (I would certainly participate, as I've been doing for a while now).

I'm not entirely sure about the best process for deciding this. The reception on Zulip was positive, but I want to make sure that everyone here is on aware and on board. Given the shared team ownership of this repo I'm going to nominate this issue for the three major teams, compiler, libs and rustdoc (rustdoc doesn't have a nomination label apparently, so I'll just @rust-lang/rustdoc here :D) . If they all agree with the change, we can implement it (by using the triagebot feature I added: rust-lang/triagebot#1708).

@Noratrieb Noratrieb added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. I-libs-nominated Nominated for discussion during a libs team meeting. I-compiler-nominated Nominated for discussion during a compiler team meeting. C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Jul 2, 2023
@jyn514
Copy link
Member

jyn514 commented Jul 5, 2023

cc @rust-lang/bootstrap

@m-ou-se
Copy link
Member

m-ou-se commented Jul 5, 2023

Sounds good. Libs team is on board.

@m-ou-se m-ou-se removed the I-libs-nominated Nominated for discussion during a libs team meeting. label Jul 5, 2023
@GuillaumeGomez
Copy link
Member

👍

@jyn514 jyn514 added the A-meta Area: Issues & PRs about the rust-lang/rust repository itself label Jul 5, 2023
@apiraino
Copy link
Contributor

apiraino commented Jul 6, 2023

Discussed in T-compiler meeting on Zulip (notes): looks like a really good idea.

@rustbot label -I-compiler-nominated

@rustbot rustbot removed the I-compiler-nominated Nominated for discussion during a compiler team meeting. label Jul 6, 2023
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Jul 7, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jul 8, 2023
compiler-errors added a commit to compiler-errors/rust that referenced this issue Jul 8, 2023
@bors bors closed this as completed in a118ce2 Jul 8, 2023
@Noratrieb
Copy link
Member Author

it's working! #113486

@fmease
Copy link
Member

fmease commented Jul 9, 2023

I think we shouldn't add needs-triage if it's a tracking issue. What's your opinion? IIUC, this can be accomplished by

  [autolabel."needs-triage"]
  new_issue = true
+ exclude_labels = [
+     "C-tracking-issue",
+ ]

@Noratrieb
Copy link
Member Author

sounds good

Noratrieb added a commit to Noratrieb/rust that referenced this issue Jul 10, 2023
…riage, r=Nilstrieb

Don't label tracking issues with `needs-triage`

Addresses rust-lang#113261 (comment).

CC `@Nilstrieb`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
7 participants