Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infinite recursion in type_structurally_contains with enums #11801

Closed
comex opened this issue Jan 25, 2014 · 1 comment
Closed

infinite recursion in type_structurally_contains with enums #11801

comex opened this issue Jan 25, 2014 · 1 comment

Comments

@comex
Copy link
Contributor

comex commented Jan 25, 2014

Test case:

pub enum Global {
    GVar(Type)
}

pub enum Type {
    TNamed(Type)
}

fn main() {}

% rustc /tmp/test.rs           
task 'rustc' has overflowed its stack
zsh: illegal hardware instruction  rustc /tmp/test.rs

Tested with 60260b6.
@huonw
Copy link
Member

huonw commented Jan 25, 2014

Thanks for the report: looks like this is a dupe of #3008.

@huonw huonw closed this as completed Jan 25, 2014
bors added a commit to rust-lang-ci/rust that referenced this issue Dec 1, 2023
@bors
Auto merge of rust-lang#11801 - y21:split_doc_pass, r=blyxyas
72c0d80 
Split `doc.rs` up into a subdirectory

So, first, sorry for the bad diff. 😅

In rust-lang#11798, `@flip1995`  suggested splitting `doc.rs` up, much like how we have the `methods/`, `matches/`, `types/` subdirectories.
I agree with this, the file is getting bigger as we add more and more doc lints that it makes sense to do this refactoring.

This is purely an internal change that moves things around a bit.
(**EDIT:** depending on the outcome of rust-lang/rust-clippy#11801 (comment) , this may change the lint group name from `doc_markdoc` to `doc`).

I tried to not change any of the actual logic of the lints and as such some things weren't as easy to move to a separate file. So we still have some `span_lint*` calls in the `doc/mod.rs` file, which I think is fine. This is also the case in `methods/mod.rs`.

Also worth mentioning that the lints missing_errors_doc, missing_panics_doc, missing_safety_doc and unnecessary_safety_doc have a lot of the same logic so it didn't make much sense for each of these to be in their own file. Instead I just put them all in `missing_headers.rs`

I also added a bit of documentation to the involved `check_{attrs,doc}` methods.

changelog: none
bors added a commit to rust-lang-ci/rust that referenced this issue Dec 1, 2023
@bors
Auto merge of rust-lang#11892 - y21:actually_rename_doc_for_real_this…
91c5653 
…_time, r=Manishearth

rename `DocMarkdown` pass to `Documentation`

Followup of rust-lang#11801

This was discussed in todays meeting: https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/Meeting.202023-11-28/near/404667082

Decided to go with `Documentation`, because this would also make it consistent with how `Attributes` is named in `attrs.rs` (and it also sounds good).

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@comex @huonw