Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammatical inconsistencies in the documentation #11830

Closed
Armavica opened this issue Jan 27, 2014 · 4 comments
Closed

Grammatical inconsistencies in the documentation #11830

Armavica opened this issue Jan 27, 2014 · 4 comments

Comments

@Armavica
Copy link
Contributor

The example of the std::num module speaks for itself. I can count at least three grammatical forms among the function descriptions:

  • indicative form (abs: Computes the absolute value.);
  • imperative form (acos: Compute the arccosine of the number.);
  • noun phrase (abs_sub: The positive difference of two numbers. or cos: Cosine function).

The various style guides (https://github.com/mozilla/rust/wiki/Note-style-guide, https://github.com/mozilla/rust/wiki/Doc-using-rustdoc and http://static.rust-lang.org/doc/master/rustdoc.html) recommend writing "sentences that begin with capital letters and end in a period" but do not mention how the sentences should be formed.

I am willing to work on making all this coherent but a convention should be fixed first.

@Armavica
Copy link
Contributor Author

Indeed, this is a duplicate of #4361, sorry.
Currently the descriptive form seems to have a small lead over the imperative form in the doc, I also personally find it more natural.

@kud1ing
Copy link

kud1ing commented Jan 28, 2014

Thanks for searching. I've transfered my comments to that issue.

@gereeter
Copy link
Contributor

If this is a duplicate, should it be closed?

@steveklabnik
Copy link
Member

Yes, it should be closed as a duplicate.

bors added a commit to rust-lang-ci/rust that referenced this issue Jul 25, 2022
On typing handler for angle brackets(<) with snippets

I implemented my idea in rust-lang#11398 in "cargo cult programming"-style without actually know what I'm doing, so feedback is welcome.  The PR is split into two commits to ease the review.  I used `@unexge's` original prototype, which forms the basis of the PR.
flip1995 pushed a commit to flip1995/rust that referenced this issue Feb 8, 2024
…p1995

Add `lint_groups_priority` lint

Warns when a lint group in Cargo.toml's `[lints]` section shares the same priority as a lint. This is in the cargo section but is categorised as `correctness` so it's on by default, it doesn't call `cargo metadata` though and parses the `Cargo.toml` directly

The lint should be temporary until rust-lang/cargo#12918 is resolved, but in the meanwhile this is an common issue to run into

- rust-lang#11237
- rust-lang#11751
- rust-lang#11830

changelog: Add [`lint_groups_priority`] lint

r? `@flip1995`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants