regression: can't call method abs on ambiguous numeric type {float}

[BoxyUwU]

• https://crater-reports.s3.amazonaws.com/beta-1.79-2/beta-2024-05-11/reg/puffpastry-0.1.0/log.txt

[INFO] [stdout] error[E0689]: can't call method `abs` on ambiguous numeric type `{float}`
[INFO] [stdout]    --> src/activation.rs:206:39
[INFO] [stdout]     |
[INFO] [stdout] 206 |         assert!((res[0] - 0.08192506).abs() < 0.001);
[INFO] [stdout]     |    

[compiler-errors]

This was probably regressed w/ some f16/f128 stuff cc @tgross35

[tgross35]

Hm, when did this last work? I can't get it to compile successfully even on older versions https://rust.godbolt.org/z/ExcMY36bf

edit: slightly more like the published test in https://docs.rs/crate/puffpastry/0.1.0/source/src/activation.rs, same results https://rust.godbolt.org/z/crWhqYq6h

[zachs18]

The puffpastry crate's bound includes T: ValidNumber<T>, which includes T: ... + From<f64> + .... Adding T: Copy + From<f64> to the example makes it compile on stable https://rust.godbolt.org/z/EbKTjzM9v

[tgross35]

Ah, then #123830 also should have removed this line https://github.com/rust-lang/rust/pull/123830/files#diff-154dff23a2c2f4fb97915229fd9c27d73293940250088020bfd2074094186ce4L173, which was added in #122470.

Was this crate the only regression of this kind? If that is the case, maybe we would be okay leaving it based on discussion at #123831.

[apiraino]

@tgross35 should the changes in #123830 / #123831 #124728 be in relnotes? I'm thinking if there are changes here useful to be announced. Thanks

[tgross35]

@apiraino I think the only things maybe relevant for release notes would be conversions that involve a stable type, which could have an effect on inference. These would be:

1. From<f16> for f64 added in f16 and f128 step 4: basic library support #122470, removed in Roll std::run into std::io::process #12380, added back in Remove std::bool::{Bool, all_values} #12473 (1.80 current nightly). Already had a crater run, no regressions
2. From<f32> for f128, added in f16 and f128 step 4: basic library support #122470 (1.79 current beta). No known regressions
3. From<f64> for f128, added in f16 and f128 step 4: basic library support #122470 (1.79 current beta). Regressions

Item 3 is the subject of this issue, we'll need a decision about whether to accept the regression or remove the impl.

The remaining conversions from #122470 shouldn't affect anything without nightly so I don't think they need release notes.

[apiraino]

probably adding t-libs then. Opened a topic for increased visibility on Zulip

@rustbot label T-libs

[tgross35]

Per https://rust-lang.zulipchat.com/#narrow/stream/259402-t-libs.2Fmeetings/topic/Meeting.202024-05-29/near/441273130, this regression is accepted. I submitted a PR to the regressed crate here uek-1/puffpastry#4

[apiraino]

I think this can be now closed as accepted, correct? cc @BoxyUwU

[tgross35]

(I feel like we should have something like a regression-accepted label to make the status of these issues clear)

[apiraino]

Closing since regression is mentioned in the release notes