Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

riscv64imac-unknown-nuttx-elf warns about abi/instruction-set mismatch #129825

Closed
saethlin opened this issue Aug 31, 2024 · 2 comments · Fixed by #129842
Closed

riscv64imac-unknown-nuttx-elf warns about abi/instruction-set mismatch #129825

saethlin opened this issue Aug 31, 2024 · 2 comments · Fixed by #129842
Labels
C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@saethlin
Copy link
Member

When using -Zbuild-std=core --target=riscv64imac-unknown-nuttx-elf I see

Hard-float 'd' ABI can't be used for a target that doesn't support the D instruction set extension (ignoring target-abi)

which seems like an indicator that something is broken.

I think LLVM is seeing a mismatch between

rust/compiler/rustc_target/src/spec/targets/riscv64imac_unknown_nuttx_elf.rs

Line 24 in 9649706

llvm_abiname: "lp64d".into(),

and the lack of a +d in

rust/compiler/rustc_target/src/spec/targets/riscv64imac_unknown_nuttx_elf.rs

Line 27 in 9649706

features: "+m,+a,+c".into(),

But of course I don't know this target, or whether this is somehow a bug in LLVM.

cc @no1wudi
@saethlin saethlin added the C-bug Category: This is a bug. label Aug 31, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Aug 31, 2024
@saethlin saethlin added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Aug 31, 2024
@no1wudi
Copy link
Contributor

no1wudi commented Sep 1, 2024

@saethlin Thanks for your report, I'll submit a fix soon, the support (include libstd/libc) for NuttX is in early stage, there are still many issues at present, sorry for that

@saethlin
Copy link
Member Author

saethlin commented Sep 1, 2024

No need to apologize, just saying something because I saw something :)

@no1wudi no1wudi mentioned this issue Sep 1, 2024
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Sep 1, 2024
@GuillaumeGomez
Rollup merge of rust-lang#129842 - no1wudi:master, r=saethlin
b3ec49e 
Fix LLVM ABI NAME for riscv64imac-unknown-nuttx-elf

This patch fix rust-lang#129825

For the riscv64imac target, the LLVM ABI NAME should be "lp64", which is the default ABI if not specified for the riscv64imac target.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Sep 2, 2024
@matthiaskrgr
Rollup merge of rust-lang#129842 - no1wudi:master, r=saethlin
efad457 
Fix LLVM ABI NAME for riscv64imac-unknown-nuttx-elf

This patch fix rust-lang#129825

For the riscv64imac target, the LLVM ABI NAME should be "lp64", which is the default ABI if not specified for the riscv64imac target.
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Sep 2, 2024
@workingjubilee
Rollup merge of rust-lang#129842 - no1wudi:master, r=saethlin
05c0de7 
Fix LLVM ABI NAME for riscv64imac-unknown-nuttx-elf

This patch fix rust-lang#129825

For the riscv64imac target, the LLVM ABI NAME should be "lp64", which is the default ABI if not specified for the riscv64imac target.
@bors bors closed this as completed in de7a14e Sep 2, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Sep 2, 2024
@rust-timer
Unrolled build for rust-lang#129842
c91f313 
Rollup merge of rust-lang#129842 - no1wudi:master, r=saethlin

Fix LLVM ABI NAME for riscv64imac-unknown-nuttx-elf

This patch fix rust-lang#129825

For the riscv64imac target, the LLVM ABI NAME should be "lp64", which is the default ABI if not specified for the riscv64imac target.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix LLVM ABI NAME for riscv64imac-unknown-nuttx-elf no1wudi/rust
3 participants
@no1wudi @saethlin @rustbot