Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build/bootstrap/.last-warned-change-id gets removed by workaround for #125578 #130449

Closed
lolbinarycat opened this issue Sep 16, 2024 · 0 comments · Fixed by #130459
Closed

build/bootstrap/.last-warned-change-id gets removed by workaround for #125578 #130449

lolbinarycat opened this issue Sep 16, 2024 · 0 comments · Fixed by #130459
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@lolbinarycat
Copy link
Contributor

bootstrap.py contains this snippet:

                # FIXME: A cheap workaround for https://github.com/rust-lang/rust/issues/125578,
                # remove this once the issue is closed.
                bootstrap_out = self.bootstrap_out()
                if os.path.exists(bootstrap_out):
                    shutil.rmtree(bootstrap_out)

                p.map(unpack_component, tarballs_download_info)

when updating to a new master, bootstrap gets rebuilt, causing the "last warned change id" file to be deleted, so you see all the "new changes to x.py", even if there are no new changes to x.py.
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 16, 2024
@lolbinarycat lolbinarycat added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Sep 17, 2024
@jieyouxu jieyouxu added the C-bug Category: This is a bug. label Sep 17, 2024
@onur-ozkan onur-ozkan removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 17, 2024
@onur-ozkan onur-ozkan mentioned this issue Sep 17, 2024
Merged
@bors bors closed this as completed in 56e5bfa Sep 27, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Sep 27, 2024
@rust-timer
Unrolled build for rust-lang#130459
f6fdc5e 
Rollup merge of rust-lang#130459 - onur-ozkan:rust-lang#130449, r=albertlarsan68

delete sub build directory "debug" to not delete the change-id file

Fixes rust-lang#130449
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

delete sub build directory "debug" to not delete the change-id file onur-ozkan/rust
4 participants
@lolbinarycat @jieyouxu @onur-ozkan @rustbot