-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"char": implement "is_whitespace" and "maybe_digit" using "std::unicode::icu" #1371
Comments
Both these tickets require that unicode.rs (and linking against libicu) is moved to core (which we try to keep small). Then again, the contents of libcore is not final yet (c_vec, dbg coming to mind). |
I sympathize with this goal. Currently we pretend to do unicode in libcore, but it's really only the ASCII-subset.
D performes similar decisions in their std.string: https://github.com/D-Programming-Language/phobos/blob/master/std/string.d The downside is a duplication of functions/interfaces. |
If one wants to do ASCII, one can always use |
I think the type "str" is not defined in module "str". Is it a bultin-in? |
I think they are both built in and thus support code for them should go to libcore. Maybe graydon can decide this? |
Sorry, i meant: I am not sure, we need the modules "char" and "str" in libcore at all. |
"is_whitespace" and "maybe_digit" should be implemented using the libicu binding in module "std::unicode::icu".
libicu is battle tested, we should not replicate their effort.
See #1370
The text was updated successfully, but these errors were encountered: