Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross-crate unboxed closures are not fully implemented #18543

Closed
bkoropoff opened this issue Nov 2, 2014 · 0 comments · Fixed by #18546
Closed

Cross-crate unboxed closures are not fully implemented #18543

bkoropoff opened this issue Nov 2, 2014 · 0 comments · Fixed by #18546

Comments

@bkoropoff
Copy link
Contributor

rust/src/librustc/middle/ty.rs

Line 4663 in d416d16

tcx.sess.bug("unimplemented cross-crate closure upvars")

Users will start running into this once #18378 is fixed
bkoropoff added a commit to bkoropoff/rust that referenced this issue Nov 2, 2014
@bkoropoff
Treat cross-crate unboxed closure def IDs consistently
9b322a6 
Always translate the ID into the local crate ID space since
presently the only way to encounter an unboxed closure type
from another crate is to inline once of its functions.

This may need to change if abstract return types are added.

Closes rust-lang#18543
bkoropoff added a commit to bkoropoff/rust that referenced this issue Nov 2, 2014
@bkoropoff
Add regression test for rust-lang#16790, rust-lang#18378 and rust-lan…
bfa5320 
…g#18543
@bkoropoff bkoropoff mentioned this issue Nov 2, 2014
Merged
bors added a commit that referenced this issue Nov 5, 2014
@bors
auto merge of #18546 : bkoropoff/rust/unboxed-closures-cross-crate, r…
98958bc 
…=nick29581

This fixes some metadata/AST encoding problems that lead to ICEs.  The way this is currently handled will need revisiting if abstract return types are added, as unboxed closure types from extern crates could show up without being inlined into the local crate.

Closes #16790 (I think this was fixed earlier by accident and just needed a test case)
Closes #18378
Closes #18543

r? @pcwalton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix some cross-crate unboxed closure bugs bkoropoff/rust
1 participant
@bkoropoff