Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no_debug and omit_gdb_pretty_printer_sections attributes exist and are ungated #28091

Closed
huonw opened this issue Aug 29, 2015 · 4 comments
Closed
Labels
A-attributes Area: #[attributes(..)] A-stability Area: issues related to #[stable] and #[unstable] attributes themselves. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@huonw
Copy link
Member

huonw commented Aug 29, 2015

This compiles without a peep from the compiler:

#[no_debug]
#[omit_gdb_pretty_printer_section]
fn main() {}

The later especially seems to be purely designed for the rust testsuite, so should probably be feature gated.

(Nominating for more discussion and some sort of priority: if the decision is made to feature gate them,fixing this should just involve changing a few lines of src/libsyntax/feature_gate.rs and then adding the appropriate feature(...)s to the tests that use them.)

@huonw huonw added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-attributes Area: #[attributes(..)] I-nominated A-stability Area: issues related to #[stable] and #[unstable] attributes themselves. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 29, 2015
@alexispurslane
Copy link
Contributor

Should someone implement this?

@nikomatsakis
Copy link
Contributor

These should both be feature-gated.

@nikomatsakis
Copy link
Contributor

triage: P-medium

@rust-highfive rust-highfive added P-medium Medium priority and removed I-nominated labels Sep 17, 2015
@nikomatsakis nikomatsakis added the E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. label Sep 17, 2015
@nikomatsakis
Copy link
Contributor

Tagging with E-mentor -- I'm happy to mentor this. (nmatsakis on IRC)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-attributes Area: #[attributes(..)] A-stability Area: issues related to #[stable] and #[unstable] attributes themselves. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants