Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for no_debug feature #29721

Closed
aturon opened this issue Nov 9, 2015 · 10 comments
Closed

Tracking issue for no_debug feature #29721

aturon opened this issue Nov 9, 2015 · 10 comments
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-lang Relevant to the language team, which will review and decide on the PR/issue.

Comments

@aturon
Copy link
Member

aturon commented Nov 9, 2015

Tracks stabilization of #[no_debug].
@aturon aturon added T-lang Relevant to the language team, which will review and decide on the PR/issue. B-unstable Blocker: Implemented in the nightly compiler and unstable. labels Nov 9, 2015
@eefriedman
Copy link
Contributor

The #[no_debug] suppresses debug info for the marked function (so the function is always compiled as if -g is turned off).

If we want to let people avoid stepping into a particular function, something like gcc's "artificial" function attribute is a better idea. I can't think of any other good reason to suppress debug info.

If we do decide to stabilize this, we need some checks to make sure the attribute is only applied in places where it's actually supported.

@nrc nrc added the T-tools label Aug 17, 2016
@nrc
Copy link
Member

nrc commented Aug 17, 2016

Is anyone using this? What is the motivation for it existing?

Nominating for discussion/FCP (my opinion: deprecate unless someone really wants this).

@jonas-schievink
Copy link
Contributor

A quick GitHub search finds no use of this

@petrochenkov
Copy link
Contributor

Is anyone using this? What is the motivation for it existing?

I use it as a workaround for #35566.

@nikomatsakis
Copy link
Contributor

nikomatsakis commented Aug 22, 2016 •
edited by pnkfelix
Loading

Hear ye, hear ye! This unstable issue is now entering final comment period with the inclination to deprecate and remove -- basically because nobody seems to really want it.

@rust-lang/lang members, please check off your name to signal agreement. Leave a comment with concerns or objections. Others, please leave comments. Thanks!

@nrc nrc added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed I-nominated labels Aug 25, 2016
@nrc nrc mentioned this issue Oct 12, 2016
Merged
@Mark-Simulacrum Mark-Simulacrum mentioned this issue Dec 18, 2016
Merged
@alexcrichton
Copy link
Member

Deprecated in #37128, so closing.

@SimonSapin
Copy link
Contributor

The deprecation landed on 2017-10-27. Can this feature be removed? (It still has an entry at https://doc.rust-lang.org/unstable-book/language-features/no-debug.html.)

@nikomatsakis
Copy link
Contributor

nikomatsakis commented Feb 22, 2018 •
edited
Loading

@SimonSapin do it =)

@nikomatsakis
Copy link
Contributor

(Or someone else :) )

@JohnTitor
Copy link
Member

@nikomatsakis Removal is still valid? I've prepared the branch: https://github.com/JohnTitor/rust/tree/no-debug

@JohnTitor JohnTitor mentioned this issue Mar 3, 2020
Merged
Centril added a commit to Centril/rust that referenced this issue Mar 7, 2020
@Centril
Rollup merge of rust-lang#69667 - JohnTitor:no-debug, r=nikomatsakis
614cd8d 
Remove the `no_debug` feature

Context: rust-lang#29721 (comment)

r? @nikomatsakis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@alexcrichton @nikomatsakis @SimonSapin @aturon @nrc @jonas-schievink @petrochenkov @eefriedman @JohnTitor