-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify BuilderHasherDefault summary #31242
Comments
@alexcrichton any thoughts on making the semantics here more clear? I'm not mega familiar with the Hash stuff. |
I was basically just attempting with words to describe the trait impls on |
I would be happy to work with anyone who wants to work on this issue. |
@steveklabnik I would be glad to help out :-) What's the best way to start on this? I am trying to find the source for the docs and I am ending up here, but somehow I think I am wrong. |
Hey @adrianbrink ! Thanks :) That's the directory for all of the long-form docs. The API documentation is in the source. With this specific bit of docs, it's here: Lines 251 to 255 in 9316ae5
So modifying these lines is where you need to go! Feel free to take a shot at it and just open a PR; we can workshop specific wording if you'd like in the PR itself. 😄 |
Opened a PR for this: #38334. |
Oh sorry, I just realized now that it's tagged |
…laumeGomez Rewrite, improve documentation for `core::hash::BuildHasherDefault`. Fixes rust-lang#31242.
…laumeGomez Rewrite, improve documentation for `core::hash::BuildHasherDefault`. Fixes rust-lang#31242.
…laumeGomez Rewrite, improve documentation for `core::hash::BuildHasherDefault`. Fixes rust-lang#31242.
…laumeGomez Rewrite, improve documentation for `core::hash::BuildHasherDefault`. Fixes rust-lang#31242.
This line is not clear:
I don't know if BuilderHasherDefault implements BuilderHasher and Default for Hasher types, or if it implements BuilderHasher for Hasher types that themselves implement Default.
The text was updated successfully, but these errors were encountered: