Spurious timeout in test net::tcp::tests::close_read_wakes_up #31657
Labels
A-spurious
Area: Spurious failures in builds (spuriously == for no apparent reason)
Comments
|
This seems to be relevant. A thread may not wake up on Windows if a socket is shut down. |
|
Hm that just seems to indicate that the child will eventually wake up... I wonder if |
This was referenced May 1, 2016
alexcrichton
added
the
A-spurious
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this issue
Jan 6, 2017
It looks like in practice at least this test will not pass on Windows. Empirically it is prone to blocking forever, presumably because a call to `shutdown` doesn't actually wake up other threads on Windows. We don't document this as a guarantee for `shutdown`, nor do we internally rely on it. This test originated in a time long since passed when it was leveraged for canceling I/O, but nowadays there's nothing fancy happening in the standard library so it's not really a productive test anyway, hence just ignoring it on Windows. Closes rust-lang#31657
This was referenced Jan 6, 2017
bors
added a commit
that referenced
this issue
Jan 12, 2017
std: Ignore close_read_wakes_up on Windows It looks like in practice at least this test will not pass on Windows. Empirically it is prone to blocking forever, presumably because a call to `shutdown` doesn't actually wake up other threads on Windows. We don't document this as a guarantee for `shutdown`, nor do we internally rely on it. This test originated in a time long since passed when it was leveraged for canceling I/O, but nowadays there's nothing fancy happening in the standard library so it's not really a productive test anyway, hence just ignoring it on Windows. Closes #31657
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this issue
Mar 8, 2022
…, r=Mark-Simulacrum Enable `close_read_wakes_up` test on Windows I wonder if we could/should try enabling this again? It was closed by rust-lang#38867 due to rust-lang#31657. I've tried running this test (along with other tests) on my machine a number of times and haven't seen this fail yet, Caveat: the worst that can happen is this succeeds initially but then causes random hangs in CI. This is not a great failure mode and would be a reason not to do this. If this does work out, closes rust-lang#39006 r? `@Mark-Simulacrum`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It just happend with my unrelated pull request on auto-win-msvc-32-opt.
It is the only test that dit not complete between this build and the previous.
It also contains the comment: "this test will never finish if the child doesn't wake up"
The text was updated successfully, but these errors were encountered: