Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

./configure fails on windows when cmake is installed on a file path containing spaces #34490

Closed
CensoredUsername opened this issue Jun 26, 2016 · 3 comments
Closed

./configure fails on windows when cmake is installed on a file path containing spaces #34490

CensoredUsername opened this issue Jun 26, 2016 · 3 comments

Comments

@CensoredUsername
Copy link
Contributor

By default, cmake is installed in C:\Program Files\CMake, so this will fail on all default installations.

As far as I see, the culprit is in configure, line 1728:
(cd $LLVM_BUILD_DIR && eval "$CFG_CMAKE" $CMAKE_ARGS)

A fix for this would be changing this line to
(cd $LLVM_BUILD_DIR && eval "\"$CFG_CMAKE\"" $CMAKE_ARGS)
@CensoredUsername CensoredUsername changed the title ./configure fails on windows when cmake is installed in a folder with spaces ./configure fails on windows when cmake is installed on a file path containing spaces Jun 26, 2016
@alexcrichton
Copy link
Member

Oh dear I'm endlessly confused by shell syntax...

Thanks for the report and fix @CensoredUsername! Want to send a PR for this?

@CensoredUsername
Copy link
Contributor Author

Sure, I'll have one up in a bit.

@CensoredUsername CensoredUsername mentioned this issue Jun 27, 2016
Merged
jseyfried added a commit to jseyfried/rust that referenced this issue Jun 30, 2016
@jseyfried
Rollup merge of rust-lang#34512 - CensoredUsername:configure-fixes, r…
bd7a363 
…=alexcrichton

Support CMake installations in paths containing spaces

This solves rust-lang#34490
@CensoredUsername
Copy link
Contributor Author

This is fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @CensoredUsername