E0025 needs to be updated to new format

[sophiajt]

From: src/test/compile-fail/E0025.rs

E0025 needs span_label instead of span_note, changing it from:

error[E0025]: field `a` bound multiple times in the pattern
  --> src/test/compile-fail/E0025.rs:18:21
   |
18 |     let Foo { a: x, a: y, b: 0 } = x; //~ ERROR E0025
   |                     ^^^^
   |
note: field `a` previously bound here
  --> src/test/compile-fail/E0025.rs:18:15
   |
18 |     let Foo { a: x, a: y, b: 0 } = x; //~ ERROR E0025
   |               ^^^^

To:

error[E0025]: field `a` bound multiple times in the pattern
  --> src/test/compile-fail/E0025.rs:18:21
   |
18 |     let Foo { a: x, a: y, b: 0 } = x; //~ ERROR E0025
   |               ----  ^^^^ multiple uses of `a` in pattern
   |               |
   |               first use of `a`

[alexispurslane]

I'd like to handle this.

[sophiajt]

@ChristopherDumas - thanks for volunteering! Currently @pcn signed up for this on the big error list, though I'm thinking it's time for us to have more people working on the errors since some people get busy.

[alexispurslane]

I'll work on this, but if @pcn gets to it first, I'll not make a pull request.

[pcn]

This one is more complex than the others I've looked at. The current code in _match.rs looks like this:

rust/src/librustc_typeck/check/_match.rs

Lines 670 to 680 in 8eb12d9

	Occupied(occupied) => {
	let mut err = struct_span_err!(tcx.sess, span, E0025,
	"field `{}` bound multiple times \
	in the pattern",
	field.name);
	span_note!(&mut err, *occupied.get(),
	"field `{}` previously bound here",
	field.name);
	err.emit();
	tcx.types.err
	}

Naively changing the span_note to a span_label seems to cause an issue and I digressed to read more about lifetimes, the borrow checker, etc. but haven't been able to translate that into a good understanding and a fix. @ChristopherDumas if you've already had experience with this, I'd love to learn from you.

[bstrie]

Freeing this one up as part of the final push for #35233.