Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E0204 needs to be updated to new format #35381

Closed
sophiajt opened this issue Aug 5, 2016 · 2 comments
Closed

E0204 needs to be updated to new format #35381

sophiajt opened this issue Aug 5, 2016 · 2 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 5, 2016 •
edited
Loading

From: src/test/compile-fail/E0204.rs

Error E0204 needs a span_label and updated title, changing it from:

error[E0204]: the trait `Copy` may not be implemented for this type; field `ty` does not implement `Copy`
  --> src/test/compile-fail/E0204.rs:17:10
   |
17 | #[derive(Copy)] //~ ERROR E0204
   |          ^^^^
src/test/compile-fail/E0204.rs:17:10: 17:14 note: in this expansion of #[derive(Copy)] (defined in src/test/compile-fail/E0204.rs)

To:

error[E0204]: the trait `Copy` may not be implemented for this type
  --> src/test/compile-fail/E0204.rs:17:10
   |
17 | #[derive(Copy)] //~ ERROR E0204
   |          ^^^^ field `ty` does not implement `Copy`
src/test/compile-fail/E0204.rs:17:10: 17:14 note: in this expansion of #[derive(Copy)] (defined in src/test/compile-fail/E0204.rs)

Note: I'm not sure the "expansion of..." part is helpful, you could also remove that.

Seems related to #35382
@GuillaumeGomez GuillaumeGomez mentioned this issue Aug 5, 2016
Closed
@sophiajt sophiajt mentioned this issue Aug 5, 2016
Closed
@sophiajt sophiajt added A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 5, 2016
@munyari munyari mentioned this issue Aug 7, 2016
Merged
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 7, 2016
Rollup merge of rust-lang#35455 - munyari:e0204, r=jonathandturner
1703f87 
Update E0204 to the new error format

Part of rust-lang#35233

Addresses rust-lang#35381
"r? @jonathandturner
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 7, 2016
Rollup merge of rust-lang#35455 - munyari:e0204, r=jonathandturner
cfebba5 
Update E0204 to the new error format

Part of rust-lang#35233

Addresses rust-lang#35381
"r? @jonathandturner
@KiChjang
Copy link
Member

KiChjang commented Aug 8, 2016

@munyari Are you also working on the bonus part of this issue?

@sophiajt
Copy link
Contributor Author

@KiChjang - the expansion note should be gone now, so I'm going to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sophiajt @KiChjang