Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSP430, unrecognized character `@' in symbol names. #38116

Closed
pftbest opened this issue Dec 1, 2016 · 0 comments
Closed

MSP430, unrecognized character `@' in symbol names. #38116

pftbest opened this issue Dec 1, 2016 · 0 comments

Comments

@pftbest
Copy link
Contributor

pftbest commented Dec 1, 2016

So I tried to compile core and I get this errors from assembler:

core.s: Assembler messages:
core.s:9468: Error: junk at end of line, first unrecognized character is `@'
core.s:9740: Error: junk at end of line, first unrecognized character is `@'
...

the code on line 9468 looks like this:

_ZN4core3num7dec2flt5rawfp10prev_float14_MSG_FILE_LINE17h5bcd06a3b0d78233E:
    .short  str.3@
    .short  27
    .short  str.1v

I tried both msp430-gcc (4.6.3) and msp430-elf-gcc (5.3.0) and both give the same errors. Then I've renamed symbol str.3@ to str.3_at in assembly and it compiled successfully. I think msp430 assembler just does not like @ character in symbol names. So I see 2 options:

  1. Modify MSP430 target in LLVM so it will rename symbols with @
  2. Modify generate_local_symbol_name to not emit @ on MSP430
pftbest added a commit to pftbest/rust that referenced this issue Dec 12, 2016
MSP430 assembler does not like '@' character in symbol names, so we should
only use alphanumerics when we generate a new name.

Fixes rust-lang#38116
bors added a commit that referenced this issue Dec 13, 2016
[MSP430] Do not generate '@' character in symbol names.

MSP430 assembler does not like '@' character in symbol names, so we need
to replace it with some other character.

Fixes #38116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant