Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Src link for re-exported macros are missing. #38951

Closed
cbreeden opened this issue Jan 9, 2017 · 1 comment · Fixed by #49982
Closed

Src link for re-exported macros are missing. #38951

cbreeden opened this issue Jan 9, 2017 · 1 comment · Fixed by #49982
Labels
C-bug Category: This is a bug. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@cbreeden
Copy link
Contributor

cbreeden commented Jan 9, 2017

Consider https://doc.rust-lang.org/core/macro.write.html which has a [Src] link, but https://doc.rust-lang.org/std/macro.write.html does not. The Std docs typically have higher visibility as it's what's linked from the docs.rust-lang.org homepage.
@cbreeden
Copy link
Contributor Author

One thought I had was to create a exported_macros.html file in the src/ directory of the docs to link to; a place to put the src of the macros and format them.

mbrubeck suggested having rustdoc specifically look at #[macro_reexport(...)] attributes like found here https://doc.rust-lang.org/src/std/up/src/libstd/lib.rs.html#314-318. Perhaps it's possible to then obtain the proper path from the macro for creating a [src] link.

@Mark-Simulacrum Mark-Simulacrum added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jun 23, 2017
@Mark-Simulacrum Mark-Simulacrum added C-bug Category: This is a bug. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. labels Jul 26, 2017
@petrochenkov petrochenkov mentioned this issue Apr 15, 2018
Merged
bors added a commit that referenced this issue May 1, 2018
@bors
Auto merge of #49982 - petrochenkov:noreex, r=alexcrichton
96b09e0 
Remove unstable `macro_reexport`

It's subsumed by `feature(use_extern_macros)` and `pub use`

cc #35896
closes #29638
closes #38951
@ollie27 ollie27 mentioned this issue Jun 6, 2018
Merged
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Jun 6, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#51389 - ollie27:rustdoc_cross_macro_src_sta…
1ad4b32 
…b, r=QuietMisdreavus

rustdoc: Fix missing stability and src links for inlined external macros

Fixes rust-lang#38951

r? @QuietMisdreavus
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Jun 7, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#51389 - ollie27:rustdoc_cross_macro_src_sta…
b4c2ad8 
…b, r=QuietMisdreavus

rustdoc: Fix missing stability and src links for inlined external macros

Fixes rust-lang#38951

r? @QuietMisdreavus
kennytm added a commit to kennytm/rust that referenced this issue Jun 7, 2018
@kennytm
Rollup merge of rust-lang#51389 - ollie27:rustdoc_cross_macro_src_sta…
d5759da 
…b, r=QuietMisdreavus

rustdoc: Fix missing stability and src links for inlined external macros

Fixes rust-lang#38951

r? @QuietMisdreavus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unstable macro_reexport petrochenkov/rust
2 participants
@Mark-Simulacrum @cbreeden