Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc --help prints full path to arg0 #39310

Closed
brson opened this issue Jan 26, 2017 · 1 comment · Fixed by #39312
Closed

rustdoc --help prints full path to arg0 #39310

brson opened this issue Jan 26, 2017 · 1 comment · Fixed by #39312
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@brson
Copy link
Contributor

brson commented Jan 26, 2017 

brian@ip-10-145-43-250:~/dev⟫ rustdoc --help
/home/brian/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/bin/rustdoc [options] <input>

Options:
    -h --help           show this help message
    -V --version        print rustdoc's version
    -v --verbose        use verbose output
    -r --input-format [rust]

No other rust tools do this. Just hard-code 'rustdoc' here.
@brson brson added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. I-wrong labels Jan 26, 2017
@mgattozzi
Copy link
Contributor

I'll take a crack at it. Quickly looking at the code this is probably where it messes up right?

rust/src/librustdoc/lib.rs

Line 194 in ecff71a

usage(&args[0]);

@mgattozzi mgattozzi mentioned this issue Jan 26, 2017
Merged
frewsxcv added a commit to frewsxcv/rust that referenced this issue Feb 5, 2017
@frewsxcv
Rollup merge of rust-lang#39312 - mgattozzi:rustdoc-help-fix, r=alexc…
5cfd5ed 
…richton

Fix full path being output with `rustdoc -h`

rustdoc would output the full path to the binary when calling it with
the `-h` or `--help` flags. This is undesired behavior. It has been
replaced with a hardcoded string `rustdoc` to fix the issue.

Fixes rust-lang#39310
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix full path being output with rustdoc -h
2 participants
@brson @mgattozzi