Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move COMPILER_TESTS.md out of the root directory #39896

Closed
brson opened this issue Feb 17, 2017 · 3 comments
Closed

Move COMPILER_TESTS.md out of the root directory #39896

brson opened this issue Feb 17, 2017 · 3 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Feb 17, 2017

This has bothered me for a while. I like to keep this directory as pristine as possible, and this file looks out of context. It is not documentation one needs to see on first glance of the project, and we don't otherwise have any convention of putting docs into the root dir.

One easy change would be to put this file in src/test, though it's unlikely to be discovered there (which is a problem probably with a number of such documents in the tree). I'd prefer that to having this single document out of place in the root.
@brson brson added A-docs E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. labels Feb 17, 2017
@steveklabnik
Copy link
Member

steveklabnik commented Feb 17, 2017 via email

@danobi danobi mentioned this issue Feb 25, 2017
Merged
@danobi
Copy link
Contributor

danobi commented Feb 25, 2017

Perhaps include a link into the source tree on https://forge.rust-lang.org/test-suite.html ?

eddyb added a commit to eddyb/rust that referenced this issue Feb 25, 2017
@eddyb
Rollup merge of rust-lang#40086 - danobi:move-compiler_tests, r=brson
9e919ad 
Move COMPILER_TESTS.md out of the root directory

See rust-lang#39896.

r? @brson
eddyb added a commit to eddyb/rust that referenced this issue Feb 25, 2017
@eddyb
Rollup merge of rust-lang#40086 - danobi:move-compiler_tests, r=brson
207c763 
Move COMPILER_TESTS.md out of the root directory

See rust-lang#39896.

r? @brson
@steveklabnik
Copy link
Member

#40086 apparently fixed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steveklabnik @brson @danobi