install.sh in distribution tarballs does not preserve executable bit #44594
Comments
|
The fix has landed in rust-installer and will arrive here with the next submodule update. (No idea how frequently these are usually done.) |
|
No submodule is updated on a regular cadence, feel free to send a PR to update it! |
|
All right, will do. |
Merged
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this issue
Sep 16, 2017
update rust-installer Fixes <rust-lang#44594> r? @alexcrichton
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this issue
Sep 16, 2017
update rust-installer Fixes <rust-lang#44594> r? @alexcrichton
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this issue
Sep 17, 2017
update rust-installer Fixes <rust-lang#44594> r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce:
./x.py distcd $SOMEWHEREtar -xzvf $RUSTC/build/dist/rust-src-1.22.0-dev.tar.gzls -lah rust-src-1.22.dev/rust-src/lib/rustlib/src/rust/src/jemalloc/include/jemalloc/Observe how some files here are executable.
mkdir foo && ./install.sh --prefix=fools -lah foo/lib/rustlib/src/rust/src/jemalloc/include/jemalloc/Expected behavior
The same files should be executable.
Actual behavior
No file is executable.
It seems rustup blissfully ignores the installer scripts here anyway, because rustup does preserve executable bits. This makes me wonder what the point of these scripts is, anyway...
The text was updated successfully, but these errors were encountered: