-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
commenting out feature flag does not affect recompilation #47003
Labels
Comments
Interesting. Thanks for the bug report, @tspiteri! |
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
Feb 19, 2018
…petrochenkov Turn feature-gate table into a query so it is covered by dependency tracking. Turn access to feature gates into a query so we handle them correctly during incremental compilation. Features are still available via `Session` through `features_untracked()`. I wish we had a better way of hiding untracked information. It would be great if we could remove the `sess` field from `TyCtxt`. Fixes rust-lang#47003.
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
Feb 24, 2018
…petrochenkov Turn feature-gate table into a query so it is covered by dependency tracking. Turn access to feature gates into a query so we handle them correctly during incremental compilation. Features are still available via `Session` through `features_untracked()`. I wish we had a better way of hiding untracked information. It would be great if we could remove the `sess` field from `TyCtxt`. Fixes rust-lang#47003.
bors
added a commit
that referenced
this issue
Mar 5, 2018
Turn feature-gate table into a query so it is covered by dependency tracking. Turn access to feature gates into a query so we handle them correctly during incremental compilation. Features are still available via `Session` through `features_untracked()`. I wish we had a better way of hiding untracked information. It would be great if we could remove the `sess` field from `TyCtxt`. Fixes #47003.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
First I compile this code with
cargo +nightly build
:Then I comment out the feature flag:
Then I recompile and it does not fail, even though the code currently requires the feature flag to compile. I guess incremental recompilation is not detecting the change.
If I
cargo clean
before recompiling, or if I completely delete the line (thus changing line numbers for the following lines), the recompilation fails as it should.The text was updated successfully, but these errors were encountered: