Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(follow-up from #47810) rustdoc: minor style nits in mobile mode #48060

Closed
QuietMisdreavus opened this issue Feb 7, 2018 · 1 comment
Closed

(follow-up from #47810) rustdoc: minor style nits in mobile mode #48060

QuietMisdreavus opened this issue Feb 7, 2018 · 1 comment
Assignees
@GuillaumeGomez
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@QuietMisdreavus
Copy link
Member

(stolen from #47810 (comment) now that the PR is merged)

The padding on the top bar seems to be rendered in a different color? It's really subtle in the dark theme, but in the light theme it sticks out. Strangely, when viewing this in Chrome, the color resets to the "proper" one when i start mousing over elements in the inspector (which causes them to be highlighted in the page), so this may be a Chrome thing.

image

I like how the theme button is next to the search box now, but i guess i expected it to disappear under the menu when it's open? Right now it's just hovering awkwardly over the search box.

image

cc @GuillaumeGomez
@GuillaumeGomez
Copy link
Member

Thanks for the issue report! I'll fix it in a few days.

@GuillaumeGomez GuillaumeGomez self-assigned this Feb 7, 2018
@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools labels Feb 7, 2018
@GuillaumeGomez GuillaumeGomez mentioned this issue Feb 8, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this issue Feb 9, 2018
@kennytm
Rollup merge of rust-lang#48080 - GuillaumeGomez:mobile-docs-fixes, r…
434865d 
…=QuietMisdreavus Hide theme button under menu in mobile mode and fix top margin issue … Fixes rust-lang#48060.
kennytm added a commit to kennytm/rust that referenced this issue Feb 9, 2018
@kennytm
Rollup merge of rust-lang#48080 - GuillaumeGomez:mobile-docs-fixes, r…
cbc3b8c 
…=QuietMisdreavus

Hide theme button under menu in mobile mode and fix top margin issue …

Fixes rust-lang#48060.

r? @QuietMisdreavus
kennytm added a commit to kennytm/rust that referenced this issue Feb 10, 2018
@kennytm
Rollup merge of rust-lang#48080 - GuillaumeGomez:mobile-docs-fixes, r…
a580eef 
…=QuietMisdreavus

Hide theme button under menu in mobile mode and fix top margin issue …

Fixes rust-lang#48060.

r? @QuietMisdreavus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GuillaumeGomez @QuietMisdreavus