Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't run MIR optimization passes during cargo check builds. #48662

Closed
michaelwoerister opened this issue Mar 2, 2018 · 0 comments
Closed

Don't run MIR optimization passes during cargo check builds. #48662

michaelwoerister opened this issue Mar 2, 2018 · 0 comments
Labels
A-metadata Area: Crate metadata I-compiletime Issue: Problems and improvements with respect to compile times. WG-compiler-performance Working group: Compiler Performance

Comments

@michaelwoerister
Copy link
Member

When build with cargo check we only create crate metadata, which is enough to compile downstream crates. Crate metadata contains the MIR of many items. Usually, this MIR is optimized before being stored in metadata. For cargo check this doesn't make sense though because the MIR is only used for analysis, never for codegen. Let's not do this unnecessary work.
@michaelwoerister michaelwoerister added A-metadata Area: Crate metadata I-compiletime Issue: Problems and improvements with respect to compile times. WG-compiler-performance Working group: Compiler Performance labels Mar 2, 2018
@varkor varkor mentioned this issue Mar 27, 2018
Merged
bors added a commit that referenced this issue Apr 3, 2018
@bors
Auto merge of #49433 - varkor:metadata-skip-mir-opt, r=<try>
a856992 
Skip MIR optimisation for cargo check

Resolves #48662.

r? @michaelwoerister
bors added a commit that referenced this issue Apr 10, 2018
@bors
Auto merge of #49433 - varkor:metadata-skip-mir-opt, r=<try>
f2c12f4 
Skip MIR encoding for cargo check

Resolves #48662.

r? @michaelwoerister
bors added a commit that referenced this issue Apr 16, 2018
@bors
Auto merge of #49433 - varkor:metadata-skip-mir-opt, r=michaelwoerister
d6a2dd9 
Skip MIR encoding for cargo check

Resolves #48662.

r? @michaelwoerister
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-metadata Area: Crate metadata I-compiletime Issue: Problems and improvements with respect to compile times. WG-compiler-performance Working group: Compiler Performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelwoerister