Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move the update-reference.sh script into x.py #49815

Closed
nikomatsakis opened this issue Apr 9, 2018 · 4 comments · Fixed by #50806
Closed

move the update-reference.sh script into x.py #49815

nikomatsakis opened this issue Apr 9, 2018 · 4 comments · Fixed by #50806
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc

Comments

@nikomatsakis
Copy link
Contributor

The script that updates reference files for UI tests is currently a shell script, which has portability issues. It is also a bit annoying to use since you must specify the path to your build directory and so forth. It'd be nice to fix all these problems and move it into x.py.

@nikomatsakis
Copy link
Contributor Author

nikomatsakis commented Apr 9, 2018

I think I would like it to work like this:

  • ./x.py bless
    • Updates all references through the test suite.
    • Rather like update-all-references.sh today
  • ./x.py bless src/test/ui/foo*.rs
    • Updates the references for some particular test(s).
    • Rather like update-reference.sh today
  • Maybe some way to specify the target, revision?
    • This seems less important.

@nikomatsakis
Copy link
Contributor Author

cc @petrochenkov, who may have opinions on this topic.

@nikomatsakis
Copy link
Contributor Author

cc @ehuss, who mentioned being up for doing the leg work =)

@nikomatsakis nikomatsakis added the A-testsuite Area: The testsuite used to check the correctness of rustc label Apr 9, 2018
@petrochenkov
Copy link
Contributor

Despite working on Windows, update-all-references being a shell script never bothered me due to MSYS2 (or Git Bash), but I agree that integrating it into x.py will simplify its use, especially the first use.

I also never used update-reference.sh personally, only update-all-references.sh. The latter works quite fast so I'm not sure why the former is necessary.

ehuss added a commit to ehuss/rust that referenced this issue May 4, 2018
kennytm added a commit to kennytm/rust that referenced this issue May 4, 2018
…crichton

Fix update-references for tests within subdirectories.

Fixes rust-lang#50438.

I'll make this more robust later for rust-lang#49815.
ehuss added a commit to ehuss/rust that referenced this issue May 9, 2018
alexcrichton added a commit to alexcrichton/rust that referenced this issue May 10, 2018
…crichton

Fix update-references for tests within subdirectories.

Fixes rust-lang#50438.

I'll make this more robust later for rust-lang#49815.
alexcrichton added a commit to alexcrichton/rust that referenced this issue May 10, 2018
…crichton

Fix update-references for tests within subdirectories.

Fixes rust-lang#50438.

I'll make this more robust later for rust-lang#49815.
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue May 17, 2018
Add `bless` x.py subcommand for easy ui test replacement

fixes rust-lang#49815

r? @nikomatsakis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants