Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constant evaluation regression in beta 1.26 #49930

Closed
2 tasks done
pietroalbini opened this issue Apr 13, 2018 · 10 comments
Closed
2 tasks done

Constant evaluation regression in beta 1.26 #49930

pietroalbini opened this issue Apr 13, 2018 · 10 comments
Labels
A-const-fn Area: const fn foo(..) {..}. Pure functions which can be applied at compile time. C-bug Category: This is a bug. P-high High priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone
1.26

Comments

@pietroalbini
Copy link
Member

pietroalbini commented Apr 13, 2018 •
edited by oli-obk
Loading

There were some constant evaluation failures in the beta crater run.

The first crate is actually deprecated/abandoned, and the second regression only appears in an old version (the latest is version 0.5.0). cc @oli-obk
@pietroalbini pietroalbini added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. A-const-fn Area: const fn foo(..) {..}. Pure functions which can be applied at compile time. C-bug Category: This is a bug. labels Apr 13, 2018
@pietroalbini pietroalbini added this to the 1.26 milestone Apr 13, 2018
@oli-obk
Copy link
Contributor

oli-obk commented Apr 13, 2018

fixing the ostn02_phf case is simple, I thought I already did that, but apparently not. I'll remove the complexity check and make it a lint as discussed in rust-lang/rfcs#2344 (comment)

@oli-obk oli-obk mentioned this issue Apr 13, 2018
Merged
bors added a commit that referenced this issue Apr 15, 2018
@bors
Auto merge of #49947 - oli-obk:turing_complete_const_eval, r=nagisa
8de5353 
Don't abort const eval due to long running evals, just warn

one check-box of #49930

r? @nagisa (rust-lang/rfcs#2344 (comment))
@pietroalbini
Copy link
Member Author

pietroalbini commented Apr 17, 2018 •
edited
Loading

The ostn02_phf fix is being backported to beta in #50027

@urschrei
Copy link
Contributor

urschrei commented Apr 17, 2018 •
edited
Loading

Is that fix also in nightly? ostn02_phf is indeed deprecated, but its replacement (ostn15_phf) has an open issue which (as I just found out) is dependent on the fix – it currently only builds on stable macOS / Linux

@urschrei urschrei mentioned this issue Apr 17, 2018
Open
@pietroalbini
Copy link
Member Author

pietroalbini commented Apr 17, 2018 •
edited
Loading

Is that fix also being backported to nightly?

@urschrei that fix is already available in the nightly (master) branch, and the PR I linked backports it to beta. The only "problem" is, since Sunday no new nightlies were released because rls is broken. Once rls will be fixed new nightlies (with the regression fixed) will be released.

@urschrei
Copy link
Contributor

@pietroalbini Thanks!

@pietroalbini
Copy link
Member Author

The ostn02_phf fix is backported to beta. What about out123-sys 0.2.1 @oli-obk?

@oli-obk
Copy link
Contributor

oli-obk commented Apr 20, 2018

nightly PR in progress: #50072

still needs a beta-accepted stamp

@pietroalbini
Copy link
Member Author

Backport PR: #50248

@nikomatsakis
Copy link
Contributor

triage: P-high

@nikomatsakis nikomatsakis added the P-high High priority label Apr 26, 2018
@pietroalbini
Copy link
Member Author

Backported to beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-const-fn Area: const fn foo(..) {..}. Pure functions which can be applied at compile time. C-bug Category: This is a bug. P-high High priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.26
Development

No branches or pull requests
4 participants
@urschrei @nikomatsakis @oli-obk @pietroalbini