Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: The default style of items inside "Implementations on Foreign Types" is very ugly #51113

Closed
kennytm opened this issue May 27, 2018 · 1 comment
Closed

rustdoc: The default style of items inside "Implementations on Foreign Types" is very ugly #51113

kennytm opened this issue May 27, 2018 · 1 comment
Assignees
@GuillaumeGomez
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@kennytm
Copy link
Member

kennytm commented May 27, 2018

Demo: https://doc.rust-lang.org/beta/alloc/slice/trait.SliceIndex.html

screenshot_2018-05-28 03 53 53_nm2wqt-fs8

There are many unnecessary elements applied to the "Implementations on Foreign Types" which probably should all be removed.

cc @QuietMisdreavus (#43849)
@kennytm kennytm added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-enhancement Category: An issue proposing an enhancement or a PR with one. labels May 27, 2018
@GuillaumeGomez
Copy link
Member

Wo, the style is completely broken. I'll fix it.

@GuillaumeGomez GuillaumeGomez self-assigned this May 28, 2018
@GuillaumeGomez GuillaumeGomez mentioned this issue May 29, 2018
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue May 31, 2018
@GuillaumeGomez
Rollup merge of rust-lang#51193 - GuillaumeGomez:fixes-style-issues, …
8efecc1 
…r=QuietMisdreavus

Fixes some style issues in rustdoc "implementations on Foreign types"

Fixes rust-lang#51113.

r? @QuietMisdreavus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kennytm @GuillaumeGomez