Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust stages for armv6/7-linux-gnueabi{hf} from static.rust-lang.org do not include rust-docs anymore #52133

Closed
stefson opened this issue Jul 7, 2018 · 7 comments
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@stefson
Copy link

stefson commented Jul 7, 2018

This is valid for >=rust-1.26.0, the rust-docs folder has been included before that version. For instance with rust-1.25.0 it was just fine. I know that there is a thing called rustup, but there are various reasons to prefere an install from the stage archives via install.sh

There were a few problems with cross compile and rust-docs in the past, this may be related somehow.

Please include rust-docs in the future, if there is a reason not to do that please communicate it. And also please check other archs for the same error, I can only speak for armv6/7! Thanks!

@Mark-Simulacrum
Copy link
Member

We no longer build documentation for these platforms; I believe the expectation is that users will use linux (x86_64-unknown-linux-gnu) documentation instead.

cc @alexcrichton

@kennytm kennytm added A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. C-feature-request Category: A feature request, i.e: not implemented / a PR. labels Jul 7, 2018
mikhail-m1 pushed a commit to mikhail-m1/rust that referenced this issue Jul 29, 2018
bors added a commit that referenced this issue Jul 29, 2018
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Jul 30, 2018
Fix wrong issue number in the test name

I made a mistake in previous PR rust-lang#52620, second issue number was wrong, changing from rust-lang#52133 to rust-lang#52113

r? @kennytm
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Jul 31, 2018
Fix wrong issue number in the test name

I made a mistake in previous PR rust-lang#52620, second issue number was wrong, changing from rust-lang#52133 to rust-lang#52113

r? @kennytm
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Aug 1, 2018
Fix wrong issue number in the test name

I made a mistake in previous PR rust-lang#52620, second issue number was wrong, changing from rust-lang#52133 to rust-lang#52113

r? @kennytm
pietroalbini added a commit to pietroalbini/rust that referenced this issue Aug 1, 2018
Fix wrong issue number in the test name

I made a mistake in previous PR rust-lang#52620, second issue number was wrong, changing from rust-lang#52133 to rust-lang#52113

r? @kennytm
@djc
Copy link
Contributor

djc commented Aug 4, 2018

This is an issue in https://bugs.gentoo.org/660512.

So where is the policy described? rust-docs is still being published for seemingly obscure target triples like i386-apple-ios, but not things like armv6 that people actually use, which seems a weird thing to do. Either it's something like one-per-OS or everything-for-tier-2.

@Mark-Simulacrum
Copy link
Member

It might be a bug that we're publishing the ios docs -- cc @kennytm

Generally speaking the policy isn't described anywhere currently (though we should probably fix that).

@djc
Copy link
Contributor

djc commented Aug 21, 2018

So can we please get some clarity on why this got changed/what the policy should look like? I'm happy to help clarify a policy and/or put it in writing, I just don't want to encode stuff now that might turn out to be wrong later because I'm guessing at motivations for this particular change.

@pietroalbini
Copy link
Member

At the moment only tier 1 platforms gets the rust-docs component packaged with rustup.

The change was made in #49187 because building those docs took a long time on our CI system (which was timing out often at the time) and we guessed few people were using those. AFAIK nobody complained (except when the change broke rustup upgrades, but that's another story).

@djc
Copy link
Contributor

djc commented Aug 30, 2018

@pietroalbini thanks, that helps a lot! It would be nice if this was documented anywhere.

@steveklabnik steveklabnik removed the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label Dec 27, 2018
@Mark-Simulacrum
Copy link
Member

I don't think we're really tracking anything in particular here -- we don't have the CI budget today to produce this documentation and there's not much we can do here today. You can mostly work around it today (presuming you have the disk space), by doing something like rustup toolchain install stable-x86_64-unknown-linux-gnu and rustup doc --toolchain stable-x86_64-unknown-linux-gnu I believe which should be sufficient for most use cases. Perhaps we ideally would default to the linux docs if we don't have the specific platform's docs but that's a rustup request more so than rust-lang/rust, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

6 participants