Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 of the ui tests fail due to the system language #54719

Closed
ljedrz opened this issue Oct 1, 2018 · 1 comment
Closed

2 of the ui tests fail due to the system language #54719

ljedrz opened this issue Oct 1, 2018 · 1 comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc

Comments

@ljedrz
Copy link
Contributor

ljedrz commented Oct 1, 2018

The following ui tests fail in a non-English Windoze setup:

  • [ui] ui\extern\external-doc-error.rs
  • [ui] ui\macros\macros-nonfatal-errors.rs

The errors are as follows:

---- [ui] ui\macros\macros-nonfatal-errors.rs stdout ----
diff of stderr:

62      LL |     include_str!(invalid); //~ ERROR
63         |                  ^^^^^^^
64
-       error: couldn't read $DIR/i'd be quite surprised if a file with this name existed: No such file or directory (os error 2)
+       error: couldn't read $DIR/i'd be quite surprised if a file with this name existed: Nie można odnaleźć określonego pliku. (os error 2)
66        --> $DIR/macros-nonfatal-errors.rs:38:5
67         |
68      LL |     include_str!("i'd be quite surprised if a file with this name existed"); //~ ERROR

74      LL |     include_bytes!(invalid); //~ ERROR
75         |                    ^^^^^^^
76
-       error: couldn't read $DIR/i'd be quite surprised if a file with this name existed: No such file or directory (os error 2)
+       error: couldn't read $DIR/i'd be quite surprised if a file with this name existed: Nie można odnaleźć określonego pliku. (os error 2)
78        --> $DIR/macros-nonfatal-errors.rs:40:5
79         |
80      LL |     include_bytes!("i'd be quite surprised if a file with this name existed"); //~ ERROR

I didn't catch the stderr of external-doc-error.rs, but judging by its applicable stderr file:

error: couldn't read $DIR/not-a-file.md: No such file or directory (os error 2)
  --> $DIR/external-doc-error.rs:16:1
   |
LL | #[doc(include = "not-a-file.md")] //~ ERROR: couldn't read
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to previous error

I'm pretty sure it's the same issue.

@estebank estebank added the A-testsuite Area: The testsuite used to check the correctness of rustc label Oct 1, 2018
This was referenced Oct 2, 2018
@petrochenkov
Copy link
Contributor

Fixed in #54813

bors added a commit that referenced this issue Oct 7, 2018
Fix two UI tests with locale-dependent output

Closes #54719
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc
Projects
None yet
Development

No branches or pull requests

3 participants