Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement "instantiation" methods in chalk integration impl #55098

Closed
nikomatsakis opened this issue Oct 15, 2018 · 0 comments · Fixed by #55921
Closed

implement "instantiation" methods in chalk integration impl #55098

nikomatsakis opened this issue Oct 15, 2018 · 0 comments · Fixed by #55921
Labels
A-traits Area: Trait system T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-traits Working group: Traits, https://internals.rust-lang.org/t/announcing-traits-working-group/6804

Comments

@nikomatsakis
Copy link
Contributor

There are a few methods in the "chalk integration" impl that have the job of "instantiating" canonical things with inference variables and the like. Actually, these methods have a somewhat bigger job: they are also supposed to create the surrounding inference context.

There are two such methods:

PR #54858 introduces a enter_with_canonical method that is more-or-less exactly what we need here (link). Hopefully that will land soon.

For reference, the implementations of these methods from the chalk project are here.

@nikomatsakis nikomatsakis added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-traits Working group: Traits, https://internals.rust-lang.org/t/announcing-traits-working-group/6804 chalk-integration A-traits Area: Trait system labels Oct 15, 2018
pietroalbini added a commit to pietroalbini/rust that referenced this issue Nov 16, 2018
Add placeholder types

Fixes rust-lang#48696 (handle universes in canonicalization of type inference vars), and fixes rust-lang#55098.
bors added a commit that referenced this issue Nov 25, 2018
Add placeholder types

Fixes #48696 (handle universes in canonicalization of type inference vars), and fixes #55098.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-traits Area: Trait system T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-traits Working group: Traits, https://internals.rust-lang.org/t/announcing-traits-working-group/6804
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant