Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing rust_eh_personality with wasm32-unknown-emscripten #55276

Closed
CryZe opened this issue Oct 23, 2018 · 2 comments
Closed

Missing rust_eh_personality with wasm32-unknown-emscripten #55276

CryZe opened this issue Oct 23, 2018 · 2 comments

Comments

@CryZe
Copy link
Contributor

CryZe commented Oct 23, 2018

When compiling with the wasm32-unknown-emscripten target, the recent nightly compilers can't seem to find the rust_eh_personality symbol. https://travis-ci.org/LiveSplit/livesplit-core/jobs/444812213#L605
It works just fine with the asmjs-unknown-emscripten target.

@nstoddard
Copy link

I've seen this too, but only when panic = 'abort' is enabled. Is that enabled for your project?

@CryZe
Copy link
Contributor Author

CryZe commented Oct 23, 2018

Yeah I have it set to abort.

CryZe added a commit to CryZe/rust that referenced this issue Nov 8, 2018
The `wasm32-unknown-emscripten` expects the `rust_eh_personality` symbol to be there, but a cfg checking for `target_arch = "wasm32"` which was meant to remove the symbol from the `wasm32-unknown-unknown` target, didn't check for whether `emscripten` is targeted or not, so the symbol accidentally got filtered out there as well.

Fixes rust-lang#55276
kennytm added a commit to kennytm/rust that referenced this issue Nov 8, 2018
wasm32-unknown-emscripten expects the rust_eh_personality symbol

The `wasm32-unknown-emscripten` expects the `rust_eh_personality` symbol to be there, but a cfg checking for `target_arch = "wasm32"` which was meant to remove the symbol from the `wasm32-unknown-unknown` target, didn't check for whether `emscripten` is targeted or not, so the symbol accidentally got filtered out there as well.

Fixes rust-lang#55276
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Nov 9, 2018
wasm32-unknown-emscripten expects the rust_eh_personality symbol

The `wasm32-unknown-emscripten` expects the `rust_eh_personality` symbol to be there, but a cfg checking for `target_arch = "wasm32"` which was meant to remove the symbol from the `wasm32-unknown-unknown` target, didn't check for whether `emscripten` is targeted or not, so the symbol accidentally got filtered out there as well.

Fixes rust-lang#55276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants