Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make performs a download #5705

Closed
pnathan opened this issue Apr 3, 2013 · 3 comments
Closed

make performs a download #5705

pnathan opened this issue Apr 3, 2013 · 3 comments

Comments

@pnathan
Copy link

pnathan commented Apr 3, 2013

When you download the 0.6 tarball and execute ./configure && make, a download occurs.

fetch: x86_64-unknown-linux-gnu/stage0/bin/rustc
determined most recent snapshot: rust-stage0-2013-03-28-f7a2371-linux-x86_64-61a4377c6d0ca5814c2b2b752d73b61b741a23c9.tar.bz2

and a wget info dump appears.

It would be really awesome if this piece was integrated with the tarball. Not all environments are friendly to downloading arbitrary code off the net. E.g., I might be in a SCIF[1] and experimenting with Rust on a machine disconnected from the public net. Or I might be on a laptop working in a no-wifi area. :-/

(I know this is probably a real low priority issue, but it IS a (usually minor) hassle)

[1] https://en.wikipedia.org/wiki/Sensitive_Compartmented_Information_Facility

@lucab
Copy link
Contributor

lucab commented Apr 4, 2013

Please note that you can avoid that if you already have a (compatible) locally installed rust compiler. Check the --local-rust and --local-rust-root parameters for ./configure.
Also, I'm against bundling binaries in source tarballs. They are target-dependent and bundling all of them will make the released archive quite large.

Downloading an external bootstrapper is a minor issue for downstream packagers too, though. See https://github.com/mozilla/rust/wiki/Note-packaging

@catamorphism
Copy link
Contributor

far-future

@graydon
Copy link
Contributor

graydon commented Jul 12, 2013

Yeah, you can also just populate the dl/ directory in your builddir with an appropriate snapshot tarball. There's not much else we can do here. Putting binaries in a source tarball feels even worse, to me. Closing as I don't expect we're going to much change the requirements here and have several workable workarounds.

@graydon graydon closed this as completed Jul 12, 2013
flip1995 added a commit to flip1995/rust that referenced this issue Jun 23, 2020
Downgrade unnested_or_patterns to pedantic

Even with rust-lang#5704 fixed, I don't believe it is a safe bet that if someone is using or-patterns anywhere in a codebase then they want to use it as much as possible in the whole codebase. I think it would be reasonable to reevaluate after the feature is stable. I feel that a warn-by-default lint suggesting use of an unstable feature, even if already being used in one place, is questionable.

changelog: Remove unnested_or_patterns from default set of enabled lints
flip1995 pushed a commit to flip1995/rust that referenced this issue Jun 23, 2020
Rollup of 9 pull requests

Successful merges:

 - rust-lang#5178 (clippy-driver: pass all args to rustc if --rustc is present)
 - rust-lang#5705 (Downgrade unnested_or_patterns to pedantic)
 - rust-lang#5709 (Fix ICE in consts::binop)
 - rust-lang#5710 (typo)
 - rust-lang#5712 (Remove `bar` from blacklisted names)
 - rust-lang#5713 (Use lints in Clippy that are enabled in rustc bootstrap)
 - rust-lang#5716 (Fix typo in wildcard_imports)
 - rust-lang#5724 (redundant_pattern_matching: avoid non-`const fn` calls in const contexts)
 - rust-lang#5726 (Fix typo)

Failed merges:

r? @ghost

changelog: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants