Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for .trailing_ones() + leading_ones() #57969

Closed
1 of 3 tasks
yoshuawuyts opened this issue Jan 29, 2019 · 5 comments
Closed
1 of 3 tasks

Tracking issue for .trailing_ones() + leading_ones() #57969

yoshuawuyts opened this issue Jan 29, 2019 · 5 comments
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@yoshuawuyts
Copy link
Member

yoshuawuyts commented Jan 29, 2019 •
edited by jonas-schievink
Loading

This is a tracking issue for the feature leading_trailing_ones which adds trailing_ones and leading_ones to all primitive integer types. (trailing_zeros and leading_zeros already existed before.)

TODO:

Unresolved questions

  • none so far?

Implementation History
@yoshuawuyts yoshuawuyts mentioned this issue Jan 29, 2019
Closed
@jonas-schievink jonas-schievink added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. C-feature-request Category: A feature request, i.e: not implemented / a PR. labels Jan 29, 2019
@nagisa
Copy link
Member

nagisa commented Jan 29, 2019

Lets repurpose this into a tracking issue so that you would have stuff to put into the tracking issue in the PR...

@nagisa nagisa added the C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. label Jan 29, 2019
@yoshuawuyts yoshuawuyts changed the title .trailing_ones(), leading_ones() for all number types Tracking issue for .trailing_ones() + leading_ones() Jan 30, 2019
@Mark-Simulacrum Mark-Simulacrum removed the C-feature-request Category: A feature request, i.e: not implemented / a PR. label Sep 2, 2019
@SimonSapin
Copy link
Contributor

Closing since #55715 did not land. Feel free to reopen if/when it does.

@crlf0710 crlf0710 mentioned this issue Jan 13, 2020
Merged
@crlf0710
Copy link
Member

Now that here's another PR(#68165), maybe we should reopen this issue? @SimonSapin @nagisa

@JohnTitor JohnTitor added the B-unstable Blocker: Implemented in the nightly compiler and unstable. label Feb 28, 2020
@djc
Copy link
Contributor

djc commented Jun 3, 2020

So we've had this for a while now, and it would be nice to stabilize. Seems pretty simple. Libs team folks?

@yoshuawuyts yoshuawuyts mentioned this issue Jun 5, 2020
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Jun 28, 2020
@Dylan-DPC
Rollup merge of rust-lang#73032 - yoshuawuyts:stabilize-leading_trail…
654c56d 
…ing_ones, r=Amanieu

stabilize leading_trailing_ones

This PR stabilizes the `leading_trailing_ones` feature. It's been available on nightly since the start of the year, and hasn't had any issues since. It seems unlikely we'll want to change this, so following up on @djc's suggestion in rust-lang#57969 (comment) I'd like to put forward this PR to stabilize the feature and make it part of `1.46.0`. Thanks!

cc/ @djc @rust-lang/libs
bors added a commit to rust-lang-ci/rust that referenced this issue Jun 29, 2020
@bors
Auto merge of rust-lang#73032 - yoshuawuyts:stabilize-leading_trailin…
c86039b 
…g_ones, r=Amanieu

stabilize leading_trailing_ones

This PR stabilizes the `leading_trailing_ones` feature. It's been available on nightly since the start of the year, and hasn't had any issues since. It seems unlikely we'll want to change this, so following up on @djc's suggestion in rust-lang#57969 (comment) I'd like to put forward this PR to stabilize the feature and make it part of `1.46.0`. Thanks!

cc/ @djc @rust-lang/libs
@jplatte
Copy link
Contributor

jplatte commented Jun 30, 2020

Stabilized in #73032, this issue should probably be closed.

@fitzgen fitzgen mentioned this issue Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@djc @SimonSapin @crlf0710 @nagisa @jplatte @jonas-schievink @yoshuawuyts @Mark-Simulacrum @LukasKalbertodt @JohnTitor