Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rls no longer builds after rust-lang/rust#61274 #61287

Closed
rust-highfive opened this issue May 28, 2019 · 5 comments · Fixed by #61298
Closed

rls no longer builds after rust-lang/rust#61274 #61287

rust-highfive opened this issue May 28, 2019 · 5 comments · Fixed by #61298
Assignees
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #61274, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @Centril, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @Centril, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.

@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 28, 2019
@Centril
Copy link
Contributor

Centril commented May 28, 2019

I'm going to guess that #61164 is to blame; cc @RalfJung

@Centril Centril assigned RalfJung and unassigned Centril May 28, 2019
@RalfJung
Copy link
Member

The fix is mostly to replace Scalar::Bits { bits, size } by Scalar::Raw { data, size }.

But really RLS shouldn't be using such implementation details...

@RalfJung
Copy link
Member

The logs look like the failure is in clippy, not RLS? I am confused.

[01:20:23] �[0m�[0m�[1m�[32m   Compiling�[0m clippy_lints v0.0.212 (/checkout/src/tools/clippy/clippy_lints)
[01:20:28] �[0m�[1m�[38;5;9merror�[0m�[0m�[1m: no variant `Bits` in enum `rustc_mir::interpret::Scalar<_, _>`�[0m
[01:20:28] �[0m   �[0m�[0m�[1m�[38;5;12m--> �[0m�[0msrc/tools/clippy/clippy_lints/src/consts.rs:475:36�[0m
[01:20:28] �[0m    �[0m�[0m�[1m�[38;5;12m|�[0m
[01:20:28] �[0m�[1m�[38;5;12m475�[0m�[0m �[0m�[0m�[1m�[38;5;12m| �[0m�[0m        ConstValue::Scalar(Scalar::Bits { bits: b, .. }) => match result.ty.sty {�[0m
[01:20:28] �[0m    �[0m�[0m�[1m�[38;5;12m| �[0m�[0m                           �[0m�[0m�[1m�[38;5;12m--------�[0m�[0m�[1m�[38;5;9m^^^^�[0m
[01:20:28] �[0m    �[0m�[0m�[1m�[38;5;12m| �[0m�[0m                           �[0m�[0m�[1m�[38;5;12m|�[0m
[01:20:28] �[0m    �[0m�[0m�[1m�[38;5;12m| �[0m�[0m                           �[0m�[0m�[1m�[38;5;12mvariant not found in `rustc_mir::interpret::Scalar<_, _>`�[0m
[01:20:28] 
[01:20:28] �[0m�[1m�[38;5;9merror�[0m�[0m�[1m: no variant `Bits` in enum `rustc_mir::interpret::Scalar<_, _>`�[0m
[01:20:28] �[0m   �[0m�[0m�[1m�[38;5;12m--> �[0m�[0msrc/tools/clippy/clippy_lints/src/consts.rs:475:36�[0m
[01:20:28] �[0m    �[0m�[0m�[1m�[38;5;12m|�[0m
[01:20:28] �[0m�[1m�[38;5;12m475�[0m�[0m �[0m�[0m�[1m�[38;5;12m| �[0m�[0m        ConstValue::Scalar(Scalar::Bits { bits: b, .. }) => match result.ty.sty {�[0m
[01:20:28] �[0m    �[0m�[0m�[1m�[38;5;12m| �[0m�[0m                           �[0m�[0m�[1m�[38;5;12m--------�[0m�[0m�[1m�[38;5;9m^^^^�[0m
[01:20:28] �[0m    �[0m�[0m�[1m�[38;5;12m| �[0m�[0m                           �[0m�[0m�[1m�[38;5;12m|�[0m
[01:20:28] �[0m    �[0m�[0m�[1m�[38;5;12m| �[0m�[0m                           �[0m�[0m�[1m�[38;5;12mvariant not found in `rustc_mir::interpret::Scalar<_, _>`�[0m
[01:20:28] 
[01:20:31] �[0m�[1m�[38;5;9merror�[0m�[0m�[1m: aborting due to previous error�[0m

(Great logs as usual, thanks Travis.)

@eddyb
Copy link
Member

eddyb commented May 28, 2019

@RalfJung breaking clippy breaks RLS, AFAIK.

@matthiaskrgr
Copy link
Member

rust-lang/rust-clippy#4152 will fix it, only needs ci to pass.

bors added a commit that referenced this issue May 31, 2019
submodules: update clippy from fb33fad to d2f5122

Changes:
````
Rustup to #61203
rustup #60928
rustup #61164 (which is included in #61274)
````

Fixes #61287

r? @oli-obk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants