Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement blocking file I/O using new I/O subsystem #6168

Closed
brson opened this issue May 2, 2013 · 5 comments
Closed

Implement blocking file I/O using new I/O subsystem #6168

brson opened this issue May 2, 2013 · 5 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented May 2, 2013

The new scheduler won't be ready for a long time, but we can replace core::io with a blocking implementation of the new I/O API. Need to make the implementation first though.

@emberian
Copy link
Member

emberian commented Aug 5, 2013

Newsched is in a really good place and std::rt::io::file has some stubs, marking as E-easy.

@olsonjeffery
Copy link
Contributor

Basic file io actions are implemented in std::rt::io::file and the groundwork is laid for future expansion. What is the "definition of done" for this ticket? (fwiw, I'm moving-on to immediately begin impl'ing remaining functionality).

@alexcrichton
Copy link
Member

Basic functionality is now provided in std::rt::io::native::file. Currently there is no support for doing anything other than reading/writing existing handles. Items left to-do:

  • Creating handles (FILE* and fd_t)
  • Removing files
  • Creating directories
  • Removing a directory
  • Basic stat information: get a stat, test what a path is, test if a path exists, etc.

These may just be nice wrappers around libc functionality, but they should be officially re-exported under std::rt::io::native::file as necessary.

@doy
Copy link
Contributor

doy commented Dec 31, 2013

This appears to have been fixed in 68d5510.

@alexcrichton
Copy link
Member

Good point, thanks!

bors added a commit to rust-lang-ci/rust that referenced this issue Oct 24, 2020
…eMacro, r=ebroto

Fix FP in `same_functions_in_if_condition` lint about condition as macro

Ignore expr that originate from a macro.

Fixes: rust-lang#6168

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

5 participants