Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert dataflow (and liveness, and region-inference) to use a common graph abstraction #6298

Closed
nikomatsakis opened this issue May 7, 2013 · 3 comments · Fixed by #14873
Closed

Convert dataflow (and liveness, and region-inference) to use a common graph abstraction #6298

nikomatsakis opened this issue May 7, 2013 · 3 comments · Fixed by #14873
Assignees
@nikomatsakis
Labels
A-lifetimes Area: Lifetimes / regions A-typesystem Area: The type system

Comments

@nikomatsakis
Copy link
Contributor

A needed refactoring for borrowck/liveness/etc to share code. Also to make dataflow more comphrensible and to address performance limitaitons with the current impl.
@ghost ghost assigned nikomatsakis May 7, 2013
@nikomatsakis nikomatsakis mentioned this issue May 10, 2013
Closed
@nikomatsakis
Copy link
Contributor Author

Clearing 0.7 milestone.

@nikomatsakis nikomatsakis mentioned this issue Jul 10, 2013
Merged
bors added a commit that referenced this issue Jul 12, 2013
@bors
auto merge of #7688 : nikomatsakis/rust/issue-6298-dataflow-graph, r=…
9a9c84f 
…graydon

This patch is a step towards #6298. It extracts the graph abstraction from region inference into a library, and then ports the region inference to use it. It also adds a control-flow graph abstraction that will eventually be used by dataflow. The CFG code is not yet used, but I figured better to add it so as to make later rebasing etc easier.
@thestinger
Copy link
Contributor

Triage bump, the transition to using this still needs to be completed.

@nikomatsakis nikomatsakis mentioned this issue Nov 8, 2013
Closed
@emberian
Copy link
Member

emberian commented Apr 7, 2014

To my knowledge, @pnkfelix is actively working on this.

pnkfelix added a commit to pnkfelix/rust that referenced this issue Jun 13, 2014
@pnkfelix
Revise dataflow to do a cfg-driven walk.
7062168 
Fix rust-lang#6298.

This is instead of the prior approach of emulating cfg traversal
privately by traversing AST in same way).

Of special note, this removes a special case handling of `ExprParen`
that was actually injecting a bug (since it was acting like an
expression like `(*func)()` was consuming `*func` *twice*: once from
`(*func)` and again from `*func`).  nikomatsakis was the first one to
point out that it might suffice to simply have the outer `ExprParen`
do the consumption of the contents (alone).
@pnkfelix pnkfelix mentioned this issue Jun 13, 2014
Merged
pnkfelix added a commit to pnkfelix/rust that referenced this issue Jun 16, 2014
@pnkfelix
Revise dataflow to do a cfg-driven walk.
04b9ee5 
Fix rust-lang#6298.

This is instead of the prior approach of emulating cfg traversal
privately by traversing AST in same way).

Of special note, this removes a special case handling of `ExprParen`
that was actually injecting a bug (since it was acting like an
expression like `(*func)()` was consuming `*func` *twice*: once from
`(*func)` and again from `*func`).  nikomatsakis was the first one to
point out that it might suffice to simply have the outer `ExprParen`
do the consumption of the contents (alone).
pnkfelix added a commit to pnkfelix/rust that referenced this issue Jun 18, 2014
@pnkfelix
Revise dataflow to do a cfg-driven walk.
75340f4 
Fix rust-lang#6298.

This is instead of the prior approach of emulating cfg traversal
privately by traversing AST in same way).

Of special note, this removes a special case handling of `ExprParen`
that was actually injecting a bug (since it was acting like an
expression like `(*func)()` was consuming `*func` *twice*: once from
`(*func)` and again from `*func`).  nikomatsakis was the first one to
point out that it might suffice to simply have the outer `ExprParen`
do the consumption of the contents (alone).

(This version has been updated to incorporate feedback from Niko's
review of PR 14873.)
bors added a commit that referenced this issue Jun 18, 2014
@bors
auto merge of #14873 : pnkfelix/rust/fsk-dataflow-revisions, r=nikoma…
4416b32 
…tsakis

Fix #6298.  Fix  #13767.

This also includes some drive by fixes for some other issues, noted in the commits.

I still need to integrate regression tests for some cases that I noticed were missing from our unit test suite (i.e. things that compiling rustc exposes that should have been exposed when doing `make check-stage1`).  So do not land this yet, until I get the chance to add those tests.

I just wanted to get the review process started soon, since this has been long in the coming.
@oli-obk oli-obk mentioned this issue Sep 6, 2017
Open
nivkner added a commit to nivkner/rust that referenced this issue Oct 7, 2017
@nivkner
address more FIXME whose associated issues were marked as closed
e0ac65e 
update FIXME(rust-lang#6298) to point to open issue 15020
update FIXME(rust-lang#6268) to point to RFC 811
update FIXME(rust-lang#10520) to point to RFC 1751
remove FIXME for emscripten issue 4563 and include target in `test_estimate_scaling_factor`
remove FIXME(rust-lang#18207) since node_id isn't used for `ref` pattern analysis
remove FIXME(rust-lang#6308) since DST was implemented in rust-lang#12938
remove FIXME(rust-lang#2658) since it was decided to not reorganize module
remove FIXME(rust-lang#20590) since it was decided to stay conservative with projection types
remove FIXME(rust-lang#20297) since it was decided that solving the issue is unnecessary
remove FIXME(rust-lang#27086) since closures do correspond to structs now
remove FIXME(rust-lang#13846) and enable `function_sections` for windows
remove mention of rust-lang#22079 in FIXME(rust-lang#22079) since this is a general FIXME
remove FIXME(rust-lang#5074) since the restriction on borrow were lifted
flip1995 pushed a commit to flip1995/rust that referenced this issue Nov 20, 2020
@bors
Auto merge of rust-lang#6298 - JohnTitor:fix-example, r=llogiq
5effc99 
Fix `await_holding_refcell_ref` examples for clarify

- Remove redundant `()`
- Fix variable name

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikomatsakis nikomatsakis

Labels
A-lifetimes Area: Lifetimes / regions A-typesystem Area: The type system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revise dataflow to use middle::cfg flowgraph to drive analysis. pnkfelix/rust
3 participants
@nikomatsakis @emberian @thestinger