Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miri no longer builds after rust-lang/rust#63015 #63024

Closed
rust-highfive opened this issue Jul 26, 2019 · 9 comments · Fixed by #63141
Closed

miri no longer builds after rust-lang/rust#63015 #63024

rust-highfive opened this issue Jul 26, 2019 · 9 comments · Fixed by #63141
Assignees
@eddyb @RalfJung @oli-obk
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #63015, I observed that the tool miri no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @Centril, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @Centril, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 26, 2019
@RalfJung
Copy link
Member

Miri-side fix: rust-lang/miri#860

@JohnTitor
Copy link
Member

Could we resolve this by updating Miri?

@RalfJung
Copy link
Member

Right now, no, because something broke Miri on macOS and I am not sure what.

@JohnTitor
Copy link
Member

JohnTitor commented Jul 28, 2019 •
edited
Loading

Hmm, the build passes now? Oh, I missed rust-lang/miri#862.

@RalfJung
Copy link
Member

Breakage is likely caused by #62982.

@RalfJung
Copy link
Member

Submitted fix: #63076

@JohnTitor
Copy link
Member

The fixes landed?

@RalfJung
Copy link
Member

It did, yes. There are some PRs under review on the rustc side that would break Miri again, but if you want you can update Miri so we'll get one or two nightlies with newer versions.

Btw, for using Miri on CI or so, I recommend a snippet such as:

MIRI_NIGHTLY=nightly-$(curl -s https://rust-lang.github.io/rustup-components-history/x86_64-unknown-linux-gnu/miri)
echo "Installing latest nightly with Miri: $MIRI_NIGHTLY"
rustup default "$MIRI_NIGHTLY"

This way you'll get a working Miri even if the latest nightly does not have one.

@RalfJung RalfJung mentioned this issue Jul 30, 2019
Closed
@RalfJung
Copy link
Member

(In case you open a PR, please Cc/r? me. I won't see it otherwise.)

@JohnTitor JohnTitor mentioned this issue Jul 30, 2019
Merged
bors added a commit that referenced this issue Jul 31, 2019
@bors
Auto merge of #63141 - JohnTitor:update-miri, r=RalfJung
e7ad858 
Update miri

Fixes #63024

r? @RalfJung
bors added a commit that referenced this issue Jul 31, 2019
@bors
Auto merge of #63141 - JohnTitor:update-miri, r=RalfJung
2d3b64e 
Update miri

Fixes #63024

r? @RalfJung
bors added a commit that referenced this issue Jul 31, 2019
@bors
Auto merge of #63141 - JohnTitor:update-miri, r=RalfJung
e3976ff 
Update miri

Fixes #63024

r? @RalfJung
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eddyb eddyb

@RalfJung RalfJung

@oli-obk oli-obk

Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update miri JohnTitor/rust
5 participants
@eddyb @RalfJung @oli-obk @rust-highfive @JohnTitor