Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use std in Windows test runner #6330

Closed
huonw opened this issue May 8, 2013 · 3 comments
Closed

use std in Windows test runner #6330

huonw opened this issue May 8, 2013 · 3 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc

Comments

@huonw
Copy link
Member

huonw commented May 8, 2013

As seen in #6267, when running the tests on Windows there are slightly different things in scope than when the tests are run normally. per @nikomatsakis:

The problem is that the checkfast procedure does not generate a use std at the top of the combined program that it generates. This is not really a concern of this PR in particular, but it'd be simple enough to fix. I am inclined to think, as a separate issue, that use std ought to be in the prelude. In any case, rather than JUST xfail-fasting them, can we put a comment as well explaining why? Potentially we could open an issue for this problem as well.
@emberian
Copy link
Member

see also #4193

@huonw huonw mentioned this issue Jul 29, 2013
Closed
huonw referenced this issue in huonw/rust Aug 7, 2013
@huonw
Add test for short-circuiting #[deriving(Eq,Ord,TotalEq,TotalOrd)].
4f3944a
@pnkfelix
Copy link
Member

Part of #8844.

@huonw huonw mentioned this issue Jan 31, 2014
Closed
brson added a commit to brson/rust that referenced this issue Feb 25, 2014
@brson
Remove check-fast. Closes rust-lang#4193, rust-lang#8844, rust-lang#6330
b2bb2f5 
, rust-lang#7416
brson added a commit to brson/rust that referenced this issue Mar 22, 2014
@brson
Remove check-fast. Closes rust-lang#4193, rust-lang#8844, rust-lang#6330
769c4ea 
, rust-lang#7416
alexcrichton pushed a commit to alexcrichton/rust that referenced this issue Apr 5, 2014
@brson @alexcrichton
Remove check-fast. Closes rust-lang#4193, rust-lang#8844, rust-lang#6330
ae5da74 
, rust-lang#7416
alexcrichton pushed a commit to alexcrichton/rust that referenced this issue Apr 6, 2014
@brson @alexcrichton
Remove check-fast. Closes rust-lang#4193, rust-lang#8844, rust-lang#6330
072a920 
, rust-lang#7416
@alexcrichton
Copy link
Member

Closing, #13288 removed check-fast

flip1995 pushed a commit to flip1995/rust that referenced this issue Dec 20, 2020
@bors
Auto merge of rust-lang#6330 - camsteffen:redundant-else, r=ebroto
50bca8a 
Add Redundant else lint

changelog: Add redundant_else lint

It seemed appropriate for "pedantic".

Closes rust-lang#112 \*blows off dust*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alexcrichton @pnkfelix @emberian @huonw