Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miri no longer builds after rust-lang/rust#63575 #63581

Closed
rust-highfive opened this issue Aug 15, 2019 · 4 comments · Fixed by #63596
Closed

miri no longer builds after rust-lang/rust#63575 #63581

rust-highfive opened this issue Aug 15, 2019 · 4 comments · Fixed by #63596
Assignees
Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

rust-highfive commented Aug 15, 2019

Hello, this is your friendly neighborhood mergebot.
After merging PR #63575, I observed that the tool miri no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @Centril, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @Centril, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.

This issue has been assigned to @lzutao via this comment.

@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 15, 2019
@nikomatsakis nikomatsakis added P-high High priority and removed I-nominated labels Aug 15, 2019
@nikomatsakis
Copy link
Contributor

Compiler team triage: marking as P-high, as miri should build. @RalfJung, @oli-obk -- any idea what it takes to fix this?

@RalfJung
Copy link
Member

It's already fixed in the Miri repo. Just takes someone to do the PR for rustc.

@lzutao do you want to do that?

Also @nikomatsakis, in the past we treated these as P-medium. Ultimately of course this is up to the compiler team, I personally will always treat it as high priority to keep at least the Miri repo itself working.

@nikomatsakis
Copy link
Contributor

OK. I think it ought to be high priority to keep things building, personally, but I'm happy to defer to convention for now, as we have too many P-high bugs ultimately.

@nikomatsakis nikomatsakis added P-medium Medium priority and removed P-high High priority labels Aug 15, 2019
@tesuji
Copy link
Contributor

tesuji commented Aug 15, 2019

@rustbot claim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants